Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom library name #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vhdirk
Copy link

@vhdirk vhdirk commented May 22, 2024

My crate has a dash in the name. Rust libraries can't have dashes.

@knopp
Copy link
Contributor

knopp commented May 23, 2024

It would be good to have test for this, perhaps even an integration test that ensures that the library is built correctly and ends up where it needs to be. There's already na integration test here but it builds one of the example project. Perhaps we could have a directory with test projects for the integration test.

@sneurlax
Copy link

sneurlax commented Sep 13, 2024

Is the simpler solution to not use a crate name with a dash in it at this time? Or how can I help complete this issue? I'd like to use a library with a dash in it, too :)

@sneurlax
Copy link

sneurlax commented Sep 18, 2024

You can try like

[package]
name = "monero-rust"
version = "0.0.2"
edition = "2021"

[lib]
name = "monero_rust"
path = "src/lib.rs"
crate-type = ["cdylib"]

in the crate to work around the issue.

UPDATE: this was working but now is not, not sure it will work, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants