Rework the handling of FMTID0 in OLEPropertiesContainer #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
force-pushed
the
maintain_guid_2
branch
from
d3cfb98 to
7d1a772
Compare
Numpsy
force-pushed
the
maintain_guid_2
branch
from
7d1a772 to
c05562e
Compare
|
@Numpsy Would you be able to rebase/retarget this to 3.0-poc? |
|
Hmm, though 3.0-poc actually shares no history with master... I doubt it would cherry-pick either... sorry :( |
|
The change was quite self contained, so I can have a look if it's still useful to apply on top of the other v3 changes |
|
Closing in favour of #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate/expanded take on #135, with the idea to always store the FMTID to use on construction rather than calculating it on save.
This is a draft as it still needs unit tests, I just thought i'd put it here now to query the idea of making use of the GlobalInfo/ImageContents/ImageInfo members of ContainerType - it seemed reasonable to me to use those values when appropriate as well as the document/summary information ones, but I have no experience working with those stream types so I'm not certain.