Update Terminal.Gui to 1.16.0, and make psedit compatible again #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for .NET Standard 2.0 Change from targetting .NET Standard to multi target .NET Standard 2.1 + .NET Framework 4.7.2 Updated vscode launch/tasks json files, and confirmed launching/debugging still works Updated yml workflows for github, as dotnet publish is no longer supported. We must use dotnet build as publish is not supported for multi targetting projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Terminal.Gui reference to 1.16.0, as we were previously locked on 1.10.0 due to dropped support for .NET Standard 2.0 in Terminal.Gui
In order to solve this, we now multi-target .NET Standard 2.1 & .NET Framework 4.7.2
This is a solution suggested here, and is the same approach used in PSScriptAnalyzer etc.
The psd1 file will now evaluate if its running under Core (and then load the .NET Standard 2.1 dll) and if not, then we fallback to a .NET Framework 4.7.2 based build of psedit.
Module folder now looks like this:
I also updated the following