wip MENGINE_PLUGIN_APPLE_GENERALDATAPROTECTIONREGULATION

irov · Aug 25, 2023 · 651a75b · 651a75b
1 parent d5804c2
commit 651a75b
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 22 deletions.
diff --git a/...eralDataProtectionRegulationPlugin/AppleGeneralDataProtectionRegulationScriptEmbedding.mm b/...eralDataProtectionRegulationPlugin/AppleGeneralDataProtectionRegulationScriptEmbedding.mm
@@ -14,6 +14,7 @@
 
 namespace Mengine
 {
+    //////////////////////////////////////////////////////////////////////////
     namespace Detail
     {
         //////////////////////////////////////////////////////////////////////////
@@ -33,11 +34,11 @@ static void s_AppleGeneralDataProtectionRegulation_isGDPRPass( bool _passGDPR )
         //////////////////////////////////////////////////////////////////////////
     }
     //////////////////////////////////////////////////////////////////////////
-    AppleGeneralDataProtectionRegulationScriptEmbedding::AppleGeneralDataProtectionRegulationEmbedding()
+    AppleGeneralDataProtectionRegulationScriptEmbedding::AppleGeneralDataProtectionRegulationScriptEmbedding()
     {
     }
     //////////////////////////////////////////////////////////////////////////
-    AppleGeneralDataProtectionRegulationScriptEmbedding::~AppleGeneralDataProtectionRegulationEmbedding()
+    AppleGeneralDataProtectionRegulationScriptEmbedding::~AppleGeneralDataProtectionRegulationScriptEmbedding()
     {
     }
     //////////////////////////////////////////////////////////////////////////

diff --git a/.../AppleGeneralDataProtectionRegulationPlugin/AppleGeneralDataProtectionRegulationService.h b/.../AppleGeneralDataProtectionRegulationPlugin/AppleGeneralDataProtectionRegulationService.h
@@ -20,5 +20,8 @@ namespace Mengine
     public:
         void setGDPRPass( bool _passGDPR ) override;
         bool isGDPRPass() const override;
+
+    protected:
+        bool m_passGDPR;
     };
 }
diff --git a/...AppleGeneralDataProtectionRegulationPlugin/AppleGeneralDataProtectionRegulationService.mm b/...AppleGeneralDataProtectionRegulationPlugin/AppleGeneralDataProtectionRegulationService.mm
@@ -14,6 +14,7 @@
 {
     //////////////////////////////////////////////////////////////////////////
     AppleGeneralDataProtectionRegulationService::AppleGeneralDataProtectionRegulationService()
+        : m_passGDPR(false)
     {
     }
     //////////////////////////////////////////////////////////////////////////
@@ -38,21 +39,13 @@
         LOGGER_MESSAGE( "set GDPR pass [%d]"
             , _passGDPR
         );
-
-        if (@available(iOS 14.0, *)) {
-            UIWindowScene * foregroundScene = nil;
-            for( UIWindowScene * scene in UIApplication.sharedApplication.connectedScenes ) {
-                if( scene.activationState == UISceneActivationStateForegroundActive ) {
-                    foregroundScene = scene;
-                }
-            }
-
-            if( foregroundScene != nil ) {
-                [SKStoreReviewController requestReviewInScene:foregroundScene];
-            }
-        } else if (@available(iOS 10.3, *)) {
-            [SKStoreReviewController requestReview];
-        }
+
+        m_passGDPR = _passGDPR;
+    }
+    //////////////////////////////////////////////////////////////////////////
+    bool AppleGeneralDataProtectionRegulationService::isGDPRPass() const
+    {
+        return m_passGDPR;
     }
     //////////////////////////////////////////////////////////////////////////
 }
diff --git a/src/Plugins/AppleSentryPlugin/AppleSentryApplicationDelegate.mm b/src/Plugins/AppleSentryPlugin/AppleSentryApplicationDelegate.mm
@@ -4,7 +4,7 @@
 
 #include "Kernel/BuildMode.h"
 
-#import <Sentry/Sentry.h>
+#import "Sentry/Sentry.h"
 
 @implementation AppleSentryApplicationDelegate
 

diff --git a/src/Plugins/AppleSentryPlugin/AppleSentryLoggerCapture.mm b/src/Plugins/AppleSentryPlugin/AppleSentryLoggerCapture.mm
@@ -5,7 +5,7 @@
 
 #include "Config/StdString.h"
 
-#import <Sentry/Sentry.h>
+#import "Sentry/Sentry.h"
 
 namespace Mengine
 {

diff --git a/src/Systems/ApplePersistentSystem/ApplePersistentSystem.cpp b/src/Systems/ApplePersistentSystem/ApplePersistentSystem.cpp
@@ -30,19 +30,19 @@ namespace Mengine
     //////////////////////////////////////////////////////////////////////////
     bool ApplePersistentSystem::getPersistentArguments( Char * _value, size_t _capacity ) const
     {
-        bool successful = Helper::AppleGetUserDefaultsString( "MengineApplePersistentArguments", _value, _capacity );
+        bool successful = Helper::AppleGetUserDefaultsString( "mengine.persistent.arguments", _value, _capacity );
 
         return successful;
     }
     //////////////////////////////////////////////////////////////////////////
     void ApplePersistentSystem::setPersistentArguments( const Char * _value )
     {
-        Helper::AppleSetUserDefaultsString( "MengineApplePersistentArguments", _value );
+        Helper::AppleSetUserDefaultsString( "mengine.persistent.arguments", _value );
     }
     //////////////////////////////////////////////////////////////////////////
     void ApplePersistentSystem::removePersistentArguments()
     {
-        Helper::AppleRemoveUserDefaultsString( "MengineApplePersistentArguments" );
+        Helper::AppleRemoveUserDefaultsString( "mengine.persistent.arguments" );
     }
     //////////////////////////////////////////////////////////////////////////
 }