Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Detail and AccountHistory ids Integer -> BigInteger #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Converted Detail and AccountHistory ids Integer -> BigInteger #79

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5893676
Added VSCode-related assets to .gitignore
Feb 18, 2021
978d2bd
Converted Detail and AccountHistory ids Integer -> BigInteger
Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions api/src/main/java/com/coinbase/exchange/api/accounts/AccountHistory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@
import com.coinbase.exchange.model.Detail;

import java.math.BigDecimal;
import java.math.BigInteger;

/**
* Created by irufus on 2/18/15.
*/
public class AccountHistory {
private Integer id;
private BigInteger id;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is a good idea to use BigInteger, why not just use String and we can adopt any future changes from Coinbase.

private String created_at;
private BigDecimal amount;
private BigDecimal balance;
Expand All @@ -17,11 +18,11 @@ public class AccountHistory {

public AccountHistory() {}

public Integer getId() {
public BigInteger getId() {
return id;
}

public void setId(Integer id) {
public void setId(BigInteger id) {
this.id = id;
}

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ allprojects {

group = 'com.coinbase.exchange'
description = 'Client for the Coinbase Pro API'
version = '0.11.0'
version = '0.12.0'

repositories {
mavenCentral()
Expand Down
8 changes: 5 additions & 3 deletions model/src/main/java/com/coinbase/exchange/model/Detail.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
package com.coinbase.exchange.model;

import java.math.BigInteger;

/**
* Created by irufus on 2/25/15.
*/
public class Detail {
private String order_id;
private Integer trade_id;
private BigInteger trade_id;
private String product_id;

public String getOrder_id() {
Expand All @@ -16,11 +18,11 @@ public void setOrder_id(String order_id) {
this.order_id = order_id;
}

public Integer getTrade_id() {
public BigInteger getTrade_id() {
return trade_id;
}

public void setTrade_id(Integer trade_id) {
public void setTrade_id(BigInteger trade_id) {
this.trade_id = trade_id;
}

Expand Down