Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing split percentage rounding issue #85

Merged
merged 1 commit into from
Nov 12, 2023
Merged

fixing split percentage rounding issue #85

merged 1 commit into from
Nov 12, 2023

Conversation

patlachance
Copy link
Contributor

Fixes #62/#63

@isaacharrisholt
Copy link
Owner

Looks good! I'll merge once you've got tests passing

@isaacharrisholt
Copy link
Owner

Please make sure to test with tox on your own machine :)

Also, it might be easier if you run poetry run pre-commit install to automatically run black etc. when you commit

@patlachance
Copy link
Contributor Author

Please make sure to test with tox on your own machine :)

It's done but I'm running python 3.12 and the tox test was failing only on python 3.8.
As there is no entry for tox in the makefile, I didn't think to run it. Now all tox tests pass for all of your configured python versions

Also, it might be easier if you run poetry run pre-commit install to automatically run black etc. when you commit

Thanks for the hint!

@patlachance
Copy link
Contributor Author

@isaacharrisholt anything else missing before merging?

@isaacharrisholt
Copy link
Owner

Hey @patlachance my apologies for the delay. Assuming all the tests pass, I'll get it merged and released!

@isaacharrisholt isaacharrisholt merged commit 7910874 into isaacharrisholt:main Nov 12, 2023
12 checks passed
@isaacharrisholt
Copy link
Owner

Done!

@patlachance patlachance deleted the fixes_issue_63 branch November 14, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lenient mode
2 participants