Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create english version of the current german RC text #39

Merged
merged 33 commits into from
Jan 15, 2025

Conversation

dret
Copy link
Contributor

@dret dret commented Dec 29, 2024

Here's a first version of the English translation of the current version. My plan is to use this as a good opportunity to publicize the curriculum a little better, and maybe iSAQB can help with that, @programming-wolf / @StefanZoerner ?

It also would be great to have this being incorporated in an updated RC better sooner than later. @sippsack, after this PR has been approved and merged, would you be so kind to do your tagging magic again? After that we should have a first complete version available at https://public.isaqb.org/curriculum-api/release-candidate/ which would be a good starting point for making a bit of noise about the RC.

@dret dret requested review from sippsack and thfro December 29, 2024 22:51
@dret dret linked an issue Dec 29, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 29, 2024

Build Successful! You can find a link to the downloadable artifacts below.

Name Link
Commit fce6f1b
Logs https://github.com/isaqb-org/curriculum-api/actions/runs/12786675725
Download https://github.com/isaqb-org/curriculum-api/suites/33084360176/artifacts/2433807094

Copy link
Contributor

@thfro thfro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted some typos and added very one or two questions.

Copy link
Contributor

@sippsack sippsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

01-what-to-expect-of-this-module.adoc is missing english translation

@sippsack
Copy link
Contributor

I fixed all the typos, created some new issues if the content is not clear enough, added translation for module explanation, time table and prerequisites.

It looks good so far and I will merge the current state.

@sippsack sippsack merged commit 6a5e783 into main Jan 15, 2025
1 check passed
@sippsack sippsack deleted the 26-create-english-version-of-the-current-german-rc-text branch February 19, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create English version of the current German RC text
3 participants