Fix #99

hive/CHANGELOG.md

@@ -1,4 +1,7 @@
-## 1.1.0+3
+## 1.1.1
+
+### Breaking changes
+- `object.delete()` now throws exception if object is not stored in a box
 
 ### Fixes
 - Fixed bug where `object.save()` would faild on subsequent calls

hive/lib/src/hive_object.dart

@@ -18,8 +18,7 @@ abstract class HiveObject {
   /// Persists this object.
   Future<void> save() {
     if (_box == null) {
-      throw HiveError('You have to add this object to a box first '
-          'using box.add() or box.put().');
+      throw HiveError('This object is currently not in a box.');
     }
     return _box.put(_key, this);
   }
@@ -29,7 +28,7 @@ abstract class HiveObject {
     if (_box != null) {
       return _box.delete(_key);
     } else {
-      return Future.value();
+      throw HiveError('This object is currently not in a box.');
     }
   }
 

hive/pubspec.yaml

@@ -1,6 +1,6 @@
 name: hive
 description: Lightweight and blazing fast key-value database written in pure Dart. Stronly encrypted using AES-256.
-version: 1.1.0+3
+version: 1.1.1
 author: Simon Leier <[email protected]>
 homepage: https://github.com/hivedb/hive
 

hive/test/hive_object_test.dart

@@ -72,11 +72,9 @@ void main() {
         verify(box.put('key', obj));
       });
 
-      test('throws exception if object is not in a box', () {
+      test('throws HiveError if object is not in a box', () async {
         var obj = _TestObject();
-
-        expect(() => obj.save(),
-            throwsHiveError('add this object to a box first'));
+        await expectLater(() => obj.save(), throwsHiveError('not in a box'));
       });
     });
 
@@ -91,9 +89,9 @@ void main() {
         verify(box.delete('key'));
       });
 
-      test('does nothing if object is not in a box', () {
+      test('throws HiveError if object is not in a box', () async {
         var obj = _TestObject();
-        obj.delete();
+        await expectLater(() => obj.delete(), throwsHiveError('not in a box'));
       });
     });