Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet Filter Linux ignore VLAN tagged packets #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svenauhagen
Copy link

If you define kea dhcp on an untagged interface that also has a tagged
vlan interface on top, it will see both dhcp packets (eth0 and eth0.10).

Linux has a feature for auxiliary data on raw sockets which contains
data about the vlan of the packet received.

Kea should only answer packets without a vlan in the aux data,
since those are the data send to the attached interface.
vlan data are missing on the intended interface eth0.10 but set on eth0
for the same packet.

There was a discussion about this here:

http://kea-users.7364.n8.nabble.com/Kea-users-KEA-DHCP-and-VLANS-td1618.html

Signed-off-by: Sven Auhagen [email protected]

If you define kea dhcp on an untagged interface that also has a tagged
vlan interface on top, it will see both dhcp packets (eth0 and eth0.10).

Linux has a feature for auxiliary data on raw sockets which contains
data about the vlan of the packet received.

Kea should only answer packets without a vlan in the aux data,
since those are the data send to the attached interface.
vlan data are missing on the intended interface eth0.10 but set on eth0
for the same packet.

There was a discussion about this here:

http://kea-users.7364.n8.nabble.com/Kea-users-KEA-DHCP-and-VLANS-td1618.html

Signed-off-by: Sven Auhagen <[email protected]>
@fabiodepin
Copy link

Very thanks.
I thought about doing the same thing, so you push this code.
Its work!

There was a discussion about this here:
https://gitlab.isc.org/isc-projects/kea/-/issues/1117

@svenauhagen
Copy link
Author

Hi,

ah I did not see that ticket, thanks.
I updated the PR an hour ago to memset the data to zero.
Have you tested that last patch?

@fabiodepin
Copy link

Yes.
Here that's log:
Getting IP: https://pastebin.com/j3UQirSC
Release: https://pastebin.com/mYu9krcj

@svenauhagen
Copy link
Author

Great, thank you for testing!

@fabiodepin
Copy link

Hello,

Any reason why the merge of this task is still pending?

@NetForces
Copy link

Any ETA on getting a release with this fixed merged in ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants