Refactor compressed_reference_idx, fix relative index bug
#453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subtracting the `first_real_slc_idx` was not correct: The stack planner would put 0 as the compressed index for all ministacks. Considering the 2nd ministack, if the `output_reference_idx` was 0, then `compressed_reference_idx` would be 0. Then we were slicing away the compressed, but also subtracting the number of compressed. The led to *neagtive indexes*.
scottstanie
changed the title
compressed_reference_idx, fix relative index bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtracting the
first_real_slc_idxwas not correct: The stack planner would put 0 as the compressed index for all ministacks.Considering the 2nd ministack, if the
output_reference_idxwas 0, thencompressed_reference_idxwould be 0. Then we were slicing away the compressed, but also subtracting the number of compressed. The led to neagtive indexes.