UAVSAR cropping fixes for stackStripmapApp #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfattahi
reviewed
Feb 2, 2022
|
|
||
| print('Line limits: ', ymin, ymax) | ||
| print('Original Line Limits: ', 0, frame.numberOfLines) | ||
|
|
||
| if (ymax-ymin) <= 1: | ||
| if (ymax-ymin) < 0: |
There was a problem hiding this comment.
why do you want to allow zero? Does zero mean that there is one pixel overlap?
There was a problem hiding this comment.
ping @ssangha, I think this is the only part we'd like clarification about. LGTM otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team, I am working to process UAVSAR data with
stackStripmapApp.pyand ran into a few issues when attempting to crop my scenes. Below I detail the simple changes I have made to address them:frame.image.filenameandframe.image.widthwere empty in ‘cropFrames.py’, which led to crashes. Thus ‘prepareUAVSAR_coregStack.py’ was updated to populate these fields in the shelve file.In
cropFrames.py,numpy.intis depreciated so I replaced allnp.intcalls withintFinally in
cropFrames.py, I adjusted the min/max check for each dimension so only <0 differences are flagged… Important because with long inclined swaths like UAVSAR, the user may want to only crop in one dimension, and the check fails if the other isn’t cropped.Please let me know if any further clarification/information is needed.