ERS stack processing #736
Open
ERS stack processing #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added orbit data type
The arclist file in the more complete ODR orbit files downloaded from http://www.deos.tudelft.nl/AS/pieter/Local/ERS/index.html (contains ERS-2 orbit files beyond 2003) has slight format change and the original hard coded line parser no longer works. The updated version should work both for the new and old versions of arclist.
yjzhenglamarmota
force-pushed
the
ersStack
branch
from
6d3c180
to
f226619
Compare
hfattahi
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Thanks @yjzhenglamarmota. The changes look fine to me. Would you please just remove the commented codes. Also would you please confirm this is the latest and greatest that worked for you in processing the large stack of ERS data?
Comment on lines
+66
to
+81
| # #### computation of "poly" adapted from line 339 - line 353 of Components/isceobj/Sensor/ERS_EnviSAT_SLC.py ### | ||
| ####### removed this section and added obj.extractDoppler() above instead. Doesn't seem to change anything in the processing. The latter is required for cropFrame. | ||
| # coeffs = obj.dopplerRangeTime | ||
| # dr = obj.frame.getInstrument().getRangePixelSize() | ||
| # rref = 0.5 * Const.c * obj.rangeRefTime | ||
| # r0 = obj.frame.getStartingRange() | ||
| # norm = 0.5 * Const.c / dr | ||
|
|
||
| # dcoeffs = [] | ||
| # for ind, val in enumerate(coeffs): | ||
| # dcoeffs.append( val / (norm**ind)) | ||
|
|
||
| # poly = Poly1D.Poly1D() | ||
| # poly.initPoly(order=len(coeffs)-1) | ||
| # poly.setMean( (rref - r0)/dr - 1.0) | ||
| # poly.setCoeffs(dcoeffs) |
There was a problem hiding this comment.
please remove commented code.
Comment on lines
+191
to
+196
| ###### commented the following because it is not always present in the new arclist file ############ | ||
| # arc.slrResidual = line[34:38] # Satellite laser ranging residual in cm | ||
| # arc.crossOver = line[39:43] | ||
| # arc.altimeter = line[45:49] | ||
| # arc.repeat = line[51:57] # Repeat cycle in days | ||
| # arc.version = line[58:61] # Version number |
There was a problem hiding this comment.
Please remove the commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been processing ERS1/2 data from ESA (http://esar-ds.eo.esa.int/socat/SAR_IMS_1P/) and thought it would be helpful to add the following script to stripmapStack before we can run stackStripMap.py for ERS data.
unpackFrame_ERS_ENV.py
I have also updated ODR.py because the updated Delft orbits have some format changes, and the original hard-coded line https://github.com/yjzhenglamarmota/isce2/blob/7fcf2c5662627842a788e5954778d98e2b3ca3e7/components/isceobj/Orbit/ODR.py#L185parser no longer works. The updated version work for both the old arclist files and the new ones.