Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated tol arguments from cg calls #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated tol arguments from cg calls #49

wants to merge 1 commit into from
+2 −2

Conversation

scottstanie
Copy link
Contributor

Scipy 1.13 was the last version this is allowed, and it is removed in 1.14: https://docs.scipy.org/doc/scipy-1.13.0/reference/generated/scipy.sparse.linalg.cg.html

@scottstanie scottstanie marked this pull request as ready for review October 16, 2024 13:19
@scottstanie
Copy link
Contributor Author

Actually I see you lower bounded scipy to be >=1.9, at which time they didn't have rtol. They only specified that ["atolshould be used for future compatibility"](https://docs.scipy.org/doc/scipy-1.9.0/reference/generated/scipy.sparse.linalg.cg.html) Perhaps I should removertol` instead?

piyushrpt
piyushrpt approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@piyushrpt piyushrpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piyushrpt
Copy link
Member

piyushrpt commented Oct 16, 2024 •
edited
Loading

Maybe pinning scipy to > 1.12.0 is better - since your setup seems to be picking up newer versions. I don't think we lose anything by updating this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyushrpt piyushrpt piyushrpt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottstanie @piyushrpt