fix: non-registerable event

isd-sgcu · Jan 10, 2024 · a419067 · a419067
1 parent b260633
commit a419067
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/apperror/error.go b/apperror/error.go
@@ -27,4 +27,5 @@ var (
 	ScheduleNotFound      = &AppError{"schedule-not-found", http.StatusNotFound}
 	DuplicatePeriod       = &AppError{"duplicate-period", http.StatusConflict}
 	ScheduleFull          = &AppError{"schedule-full", http.StatusBadRequest}
+	NonRegisterableEvent  = &AppError{"non-registerable-event", http.StatusBadRequest}
 )
diff --git a/internal/evtreg/evtreg.repository.go b/internal/evtreg/evtreg.repository.go
@@ -28,7 +28,7 @@ func (r *repositoryImpl) GetUserWithEventRegistrationByEmail(user *model.User, e
 }
 
 func (r *repositoryImpl) GetScheduleById(schedule *model.Schedule, scheduleId int) error {
-	return r.db.Model(schedule).Where("id = ?", scheduleId).First(schedule).Error
+	return r.db.Model(schedule).Preload("Event").Where("id = ?", scheduleId).First(schedule).Error
 }
 
 func (r *repositoryImpl) RegisterEvent(evtreg *model.EventRegistration) error {

diff --git a/internal/evtreg/evtreg.service.go b/internal/evtreg/evtreg.service.go
@@ -50,6 +50,10 @@ func (h *serviceImpl) RegisterEvent(ctx context.Context, userEmail string, sched
 		return apperror.InternalError
 	}
 
+	if !schedule.Event.RequireRegistration {
+		return apperror.NonRegisterableEvent
+	}
+
 	for _, regEvt := range user.RegisteredEvents {
 		if regEvt.Schedule.Period == schedule.Period {
 			return apperror.DuplicatePeriod