Skip to content

Commit

Permalink
chore: run lint
Browse files Browse the repository at this point in the history
  • Loading branch information
punchanabu committed Aug 31, 2024
1 parent 61f61e9 commit c3b3659
Show file tree
Hide file tree
Showing 10 changed files with 39 additions and 31 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
run: pnpm install

- name: Lint
run: pnpm lint
run: pnpm lint
25 changes: 17 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ Web Application for SUCU's website.
## Prerequisites

Please install the following.
- [Node.js](https://nodejs.org/en/)
- [pnpm](https://pnpm.io/)
- [Git](https://git-scm.com/)

- [Node.js](https://nodejs.org/en/)
- [pnpm](https://pnpm.io/)
- [Git](https://git-scm.com/)

This project use [Svelte](https://svelte.dev/docs/) and [TailwindCSS](https://tailwindcss.com/) as CSS Framework.

Expand All @@ -17,7 +18,6 @@ For front-end design you can see in [SUCU's Figma](https://www.figma.com/design/

1. Clone this repository


```bash
# Using SSH (recommended)
git clone [email protected]:isd-sgcu/sucu-frontend-2024.git
Expand All @@ -27,16 +27,19 @@ https://github.com/isd-sgcu/sucu-frontend-2024.git
```

2. Go to project folder

```bash
cd sucu-frontend-2024
```

3. Install all dependencies

```bash
pnpm install
```

4. Run

```bash
pnpm dev
```
Expand All @@ -48,35 +51,41 @@ pnpm dev
We will seperate a branch for each features and each person then, create pull request for combine code together.

1. Go to `dev` branch and pull updated code

```bash
git checkout dev

git pull
```

2. Create branch and go to your branch

```bash
git branch {your_branch_name}

git checkout {your_branch_name}
```

> Note : exmaple of {your_branch_name} is boom/feat/pet-card, aungpao/refactor/main-page
3. Push your branch upstream

```bash
git push --set-upstream origin {your_branch_name}
```

4. Working with your code

5. Stage and commit your changes

```bash
git add .

git commit -m {commit_message}
```

6. Push your code in to your branch

```bash
git push
```
Expand All @@ -102,9 +111,9 @@ git commit -m "refactor: <what-you-refactored>"

The commit message should start with one of the following types:

- feat: A new feature
- fix: A bug fix
- refactor: A code change that neither fixes a bug nor adds a feature
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
- feat: A new feature
- fix: A bug fix
- refactor: A code change that neither fixes a bug nor adds a feature
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)

For more information, please read the [conventional commit format](https://www.conventionalcommits.org/en/v1.0.0/) documentation.
10 changes: 5 additions & 5 deletions postcss.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export default {
plugins: {
tailwindcss: {},
autoprefixer: {},
},
}
plugins: {
tailwindcss: {},
autoprefixer: {}
}
};
2 changes: 1 addition & 1 deletion src/app.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@tailwind base;
@tailwind components;
@tailwind utilities;
@tailwind utilities;
4 changes: 2 additions & 2 deletions src/lib/components/Playground.svelte
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<section>
<h2>Playground</h2>
</section>
<h2>Playground</h2>
</section>
4 changes: 2 additions & 2 deletions src/lib/utils/cn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ import clsx, { type ClassValue } from 'clsx';
import { twMerge } from 'tailwind-merge';

export const cn = (...args: ClassValue[]) => {
return twMerge(clsx(args))
}
return twMerge(clsx(args));
};
2 changes: 1 addition & 1 deletion src/lib/utils/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export * from './cn';
export * from './cn';
4 changes: 2 additions & 2 deletions src/routes/+layout.svelte
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script>
import "../app.css";
import '../app.css';
</script>

<slot/>
<slot />
4 changes: 2 additions & 2 deletions src/routes/+page.svelte
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script>
import Playground from "$lib/components/Playground.svelte";
import Playground from '$lib/components/Playground.svelte';
</script>

<Playground/>
<Playground />
13 changes: 6 additions & 7 deletions tailwind.config.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
/** @type {import('tailwindcss').Config} */
export default {
content: ['./src/**/*.{html,js,svelte,ts}'],
theme: {
extend: {},
},
plugins: [],
}

content: ['./src/**/*.{html,js,svelte,ts}'],
theme: {
extend: {}
},
plugins: []
};

0 comments on commit c3b3659

Please sign in to comment.