Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macgeargear/sucu 69 page document #19

Merged
merged 17 commits into from
Sep 20, 2024
Merged

Conversation

macgeargear
Copy link
Contributor

@macgeargear macgeargear commented Sep 16, 2024

Type of Change

  • New features
  • Bug fixes
  • Breaking changes
  • Refactor
  • Documentation updates
  • Other (please specify):

Description

New Features

  • create document pages

  • mock data for document page

  • mock pagination

  • create types: document, role, user

  • create DocumentList component used in document page

FIX

  • list style
    • use cn
    • fix responsive text size
      • tailwind dynamic class not working (it seem that Tailwind doesn’t recognize dynamic string in build time)
      • so I change from md:${typography({ variant: 'body-large' })} to just md:text-2xl

NOTE

  • tap capsule cannot filter anything yet (only searchValue and dropDown can)

Screenshots or GIFs (if applicable)

Desktop

Screen.Recording.2024-09-16.at.5.12.38.PM.mov

Mobile

Uploading Screen Recording 2024-09-16 at 5.20.28 PM.mov…

@macgeargear macgeargear self-assigned this Sep 16, 2024
@punchanabu
Copy link
Member

And also the question that After we load data from +page.ts, will we keep the data in the store or not ?

  • I think we can just start with separate the data loading on each page but if it began to have an performance issues I think we have to use store

@macgeargear macgeargear merged commit 20a876b into dev Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants