Skip to content

Commit

Permalink
Add Sonar to the project
Browse files Browse the repository at this point in the history
  • Loading branch information
FerreiroAlberto committed Apr 3, 2024
1 parent 4692b39 commit eec00ac
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 1 deletion.
20 changes: 20 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Build
on:
push:
branches:
- main
pull_request:
types: [opened, synchronize, reopened]
jobs:
sonarcloud:
name: SonarCloud
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
- name: SonarCloud Scan
uses: SonarSource/sonarcloud-github-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"build": "ng build",
"watch": "ng build --watch --configuration development",
"test": "ng test",
"test:prod": "ng test --code-coverage --no-watch --browsers=ChromeHeadless",
"lint": "ng lint",
"prepare": "husky"
},
Expand Down
13 changes: 13 additions & 0 deletions sonar-project.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
sonar.projectKey=isdi-coders-2023_TeamR-Meowth-202401-mad
sonar.organization=isdi-coders-2023

# This is the name and version displayed in the SonarCloud UI.
#sonar.projectName=TeamR-Meowth-202401-mad
#sonar.projectVersion=1.0


# Path is relative to the sonar-project.properties file. Replace "\" by "/" on Windows.
#sonar.sources=.

# Encoding of the source code. Default is default system encoding
#sonar.sourceEncoding=UTF-8
2 changes: 1 addition & 1 deletion src/app/feature/card/card.component.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<li>
<img [src]="card?.imageUrl" [alt]="card?.name" />
<img [src]="card.imageUrl" [alt]="card.name" />
</li>

0 comments on commit eec00ac

Please sign in to comment.