Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CI to GitHub Actions #42

Closed
wants to merge 3 commits into from
Closed

Move CI to GitHub Actions #42

wants to merge 3 commits into from

Conversation

ActuallyConnor
Copy link

#40

@ActuallyConnor ActuallyConnor mentioned this pull request Nov 16, 2021
Open
ishanvyas22
ishanvyas22 requested changes Nov 21, 2021
View reviewed changes
Copy link
Owner

@ishanvyas22 ishanvyas22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks okay. Just a few enhancements points:

  1. Instead of different workflow files(run-phpstan, run-tests, etc.), create single ci.yml file. I suppose it would be easier to maintain in future. Ref: https://github.com/cakephp/cakephp/blob/4.x/.github/workflows/ci.yml
  2. Remove travis.yml file since it no longer needed.

@ishanvyas22 ishanvyas22 linked an issue Nov 21, 2021 that may be closed by this pull request
Move CI to GitHub Actions #40
Open
@ishanvyas22 ishanvyas22 added the enhancement New feature or request label Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishanvyas22 ishanvyas22 ishanvyas22 requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move CI to GitHub Actions
2 participants
@ActuallyConnor @ishanvyas22