Skip to content

Commit

Permalink
Fixed Ruby conformance tests by running them under rvm Ruby.
Browse files Browse the repository at this point in the history
  • Loading branch information
haberman committed Jan 12, 2016
1 parent bf50ec4 commit fc7f8d9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion ruby/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
google-protobuf (3.0.0.alpha.5.0)
google-protobuf (3.0.0.alpha.4.0)

GEM
remote: https://rubygems.org/
Expand Down
3 changes: 1 addition & 2 deletions ruby/ext/google/protobuf_c/defs.c
Original file line number Diff line number Diff line change
Expand Up @@ -543,8 +543,7 @@ VALUE FieldDescriptor_name_set(VALUE _self, VALUE str) {

upb_fieldtype_t ruby_to_fieldtype(VALUE type) {
if (TYPE(type) != T_SYMBOL) {
rb_raise(rb_eArgError, "Expected symbol for field type, not: %s (%d)",
RSTRING_PTR(rb_inspect(type)), TYPE(type));
rb_raise(rb_eArgError, "Expected symbol for field type.");
}

#define CONVERT(upb, ruby) \
Expand Down
4 changes: 2 additions & 2 deletions ruby/travis-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ test_version() {
"rvm install $version && rvm use $version && \
which ruby && \
gem install bundler && bundle && \
rake test"
cd ../conformance && make test_ruby
rake test &&
cd ../conformance && make test_ruby"
fi
}

Expand Down

0 comments on commit fc7f8d9

Please sign in to comment.