Skip to content

Commit

Permalink
Copy SampleCount when making a copy of FilamentView (#7072)
Browse files Browse the repository at this point in the history
Otherwise the copied view will not be an exact copy - it'll contain the default sample count (=4), and not the sample count of the view it's copying from.
  • Loading branch information
patrikhuber authored Dec 18, 2024
1 parent 8e43455 commit 7a1c330
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## Main
- Fix MSAA sample count not being copied when FilamentView is copied
- Fix TriangleMesh::SamplePointsUniformly and TriangleMesh::SamplePointsPoissonDisk now sampling colors from mesh if available (PR #6842)
- Fix TriangleMesh::SamplePointsUniformly not sampling triangle meshes uniformly (PR #6653)
- Fix tensor based TSDF integration example.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ void FilamentView::CopySettingsFrom(const FilamentView& other) {
if (other.color_grading_) {
view_->setColorGrading(other.color_grading_);
}
view_->setSampleCount(other.view_->getSampleCount());
auto ao_options = other.view_->getAmbientOcclusionOptions();
view_->setAmbientOcclusionOptions(ao_options);
auto aa_mode = other.view_->getAntiAliasing();
Expand Down

0 comments on commit 7a1c330

Please sign in to comment.