Add macOS arm64 CI runner, fix macOS arm64 builds, fused multi-platfo…

…rm viewer app and python wheels (#6695) * Test macOS arm64 runner * Use matrix to run jobs for both Intel and Apple SIlicon * cleanup workflow, try to fix libomp related issue * Fuse x64 and arm64 wheels, fix wheel naming & unit tests * embree 4.3.1: fix macOS arm64 compile * Add prebuilt arm64 filament binaries * Fuse viewer app * Documentation CI fix by adding lxml[html_clean] to requirements. * Fix for uploading linux CUDA artifacts to github name clash --------- Co-authored-by: Sameer Sheorey <[email protected]>
isl-org · Apr 17, 2024 · a4a173e · a4a173e
1 parent 1562468
commit a4a173e
Show file tree

Hide file tree

Showing 15 changed files with 373 additions and 78 deletions.
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -26,10 +26,13 @@ env:
 
 jobs:
   MacOS:
-    runs-on: macos-12
+    runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
+        # macos-12 is Intel runner, macos-14 is Apple Silicon
+        # https://github.com/actions/runner-images
+        os: [macos-12, macos-14]
         CONFIG: [ON, OFF]
     env:
       BUILD_SHARED_LIBS: ${{ matrix.CONFIG }}
@@ -47,26 +50,49 @@ jobs:
           path: ~/.ccache
           # We include the commit sha in the cache key, as new cache entries are
           # only created if there is no existing entry for the key yet.
-          key: ${{ runner.os }}-ccache-${{ github.sha }}
+          key: ${{ runner.os }}-${{ runner.arch }}-ccache-${{ github.sha }}
           # Restore any ccache cache entry, if none for
-          # ${{ runner.os }}-ccache-${{ github.sha }} exists.
+          # ${{ runner.os }}-${{ runner.arch }}-ccache-${{ github.sha }} exists.
           # Common prefix will be used so that ccache can be used across commits.
           restore-keys: |
-            ${{ runner.os }}-ccache
+            ${{ runner.os }}-${{ runner.arch }}-ccache
+
       - name: Set up Python version
         uses: actions/setup-python@v5
         with:
-          python-version: 3.8
+          python-version: '3.11'
+
       - name: Install dependencies
         run: |
           brew install ccache pkg-config
-          # Install libomp 11.1.0 from old brew bottle for catalina (10.15).
-          # Directly installing the Ruby formula will install for the current OS
+
+          if [[ ${{ runner.arch}} == "ARM64"  ]]; then
+            # Fix gfortran not found issue
+            ln -s $(which gfortran-13) /usr/local/bin/gfortran
+
+            # Default macos-14 image Xcode (version 15.0.1) linker causes build issues.
+            # Newer Xcode versions work, but embree recommends Apple clang <= 14 on
+            # arm64 to avoid possible "EXEC_BAD_INSTRUCTION" runtime exceptions:
+            # https://github.com/embree/embree/releases/tag/v4.3.1
+            sudo xcode-select -switch /Applications/Xcode_14.3.1.app
+          fi
+
+          # Install libomp 11.1.0 from old brew bottle for x64 catalina (10.15)
+          # / arm64 big sur (11.0). Directly installing the Ruby formula will
+          # install for the current OS.
           # https://github.com/microsoft/LightGBM/issues/4229
-          brew unlink libomp
-          curl -L -H "Authorization: Bearer QQ==" -o libomp-11.1.0.catalina.bottle.tar.gz \
-          https://ghcr.io/v2/homebrew/core/libomp/blobs/sha256:45a5aa653bd45bd5ff5858580b1a4670c4b5a51ea29d68d45a53f72f56010e05
-          brew install -f libomp-11.1.0.catalina.bottle.tar.gz
+          if [[ ${{ runner.arch}} == "X64"  ]]; then
+            brew unlink libomp
+            # x64 catalina (10.15) bottle
+            export LIBOMP_BOTTLE_HASH=45a5aa653bd45bd5ff5858580b1a4670c4b5a51ea29d68d45a53f72f56010e05
+          else # ARM64
+            # arm64 big_sur (11.0) bottle
+            export LIBOMP_BOTTLE_HASH=f87f7841eb8b72650fa771af39642361aec371ea1a1f94f081ecc0e8168a0e75
+          fi
+          curl -L -H "Authorization: Bearer QQ==" -o libomp-11.1.0.bottle.tar.gz \
+          https://ghcr.io/v2/homebrew/core/libomp/blobs/sha256:$LIBOMP_BOTTLE_HASH
+          brew install -f libomp-11.1.0.bottle.tar.gz
+
           ccache -M 2G  # See .github/workflows/readme.md for ccache strategy.
       - name: Config and build
         run: |
@@ -82,7 +108,7 @@ jobs:
           pushd build
           make -j${NPROC} Open3DViewer
           pushd bin
-          zip -rv open3d-app-macosx-10_15.zip Open3D.app
+          zip -rv open3d-app-macosx-10_15-${{ runner.arch}}.zip Open3D.app
           ccache -s
 
       - name: Upload package
@@ -116,21 +142,58 @@ jobs:
         uses: actions/upload-artifact@v4
         if: ${{ env.BUILD_SHARED_LIBS == 'OFF' }}
         with:
-          name: open3d-app-macosx-10_15
-          path: build/bin/open3d-app-macosx-10_15.zip
+          name: open3d-app-macosx-10_15-${{ runner.arch}}
+          path: build/bin/open3d-app-macosx-10_15-${{ runner.arch}}.zip
+          if-no-files-found: error
+
+  fuse-viewer:
+    name: Fuse x64 and ARM64 viewer app
+    runs-on: [macos-12]
+    needs: [MacOS]
+    steps:
+      - name: Download viewer apps
+        uses: actions/download-artifact@v4
+        with:
+          pattern: open3d-app-macosx-10_15-*
+          merge-multiple: true
+
+      - name: Fuse x64 and arm64 viewer apps
+        run: |
+          unzip open3d-app-macosx-10_15-X64.zip -d x64
+          unzip open3d-app-macosx-10_15-ARM64.zip -d arm64
+          for i in arm64/Open3D.app/Contents/MacOS/*; do
+            filepath=Open3D.app/Contents/MacOS/$(basename $i)
+            lipo -create arm64/${filepath} x64/${filepath} -output arm64/${filepath}
+          done
+          mv arm64/Open3D.app Open3D.app
+          zip -rv open3d-app-macosx-10_15-universal2.zip Open3D.app
+
+      - name: Upload Open3D viewer app
+        uses: actions/upload-artifact@v4
+        with:
+          name: open3d-app-macosx-10_15-universal2
+          path: open3d-app-macosx-10_15-universal2.zip
           if-no-files-found: error
 
   build-wheel:
     name: Build wheel
-    runs-on: macos-12
+    runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       # https://github.community/t/how-to-conditionally-include-exclude-items-in-matrix-eg-based-on-branch/16853/6
       matrix:
+        # macos-12 is Intel runner, macos-14 is Apple Silicon
+        # https://github.com/actions/runner-images
+        os: [macos-12, macos-14]
         python_version: ['3.8', '3.9', '3.10', '3.11']
         is_main:
           - ${{ github.ref == 'refs/heads/main' }}
         exclude:
+          # TODO: remove macos-14 excludes when https://github.com/actions/setup-python/issues/808 is fixed
+          - os: macos-14
+            python_version: '3.8'
+          - os: macos-14
+            python_version: '3.9'
           - is_main: false
             python_version: '3.8'
           - is_main: false
@@ -158,12 +221,12 @@ jobs:
           path: ~/.ccache
           # We include the commit sha in the cache key, as new cache entries are
           # only created if there is no existing entry for the key yet.
-          key: ${{ runner.os }}-ccache-${{ github.sha }}
+          key: ${{ runner.os }}-${{ runner.arch }}-ccache-${{ github.sha }}
           # Restore any ccache cache entry, if none for
-          # ${{ runner.os }}-ccache-${{ github.sha }} exists.
+          # ${{ runner.os }}-${{ runner.arch }}-ccache-${{ github.sha }} exists.
           # Common prefix will be used so that ccache can be used across commits.
           restore-keys: |
-            ${{ runner.os }}-ccache
+            ${{ runner.os }}-${{ runner.arch }}-ccache
 
       - name: Set up Python
         uses: actions/setup-python@v5
@@ -180,12 +243,26 @@ jobs:
           cmake --version
           source util/ci_utils.sh
           install_python_dependencies
+
+          # Fix macos-14 arm64 runner image issues, see comments in MacOS job.
+          if [[ ${{ runner.arch}} == "ARM64"  ]]; then
+            ln -s $(which gfortran-13) /usr/local/bin/gfortran
+            sudo xcode-select -switch /Applications/Xcode_14.3.1.app
+          fi
+
           # Install libomp 11.1.0. See comment above.
+          if [[ ${{ runner.arch}} == "X64"  ]]; then
+            brew unlink libomp
+            # x64 catalina (10.15) bottle
+            export LIBOMP_BOTTLE_HASH=45a5aa653bd45bd5ff5858580b1a4670c4b5a51ea29d68d45a53f72f56010e05
+          else # ARM64
+            # arm64 big_sur (11.0) bottle
+            export LIBOMP_BOTTLE_HASH=f87f7841eb8b72650fa771af39642361aec371ea1a1f94f081ecc0e8168a0e75
+          fi
+          curl -L -H "Authorization: Bearer QQ==" -o libomp-11.1.0.bottle.tar.gz \
+          https://ghcr.io/v2/homebrew/core/libomp/blobs/sha256:$LIBOMP_BOTTLE_HASH
+          brew install -f libomp-11.1.0.bottle.tar.gz
           brew install ccache
-          brew unlink libomp
-          curl -L -H "Authorization: Bearer QQ==" -o libomp-11.1.0.catalina.bottle.tar.gz \
-          https://ghcr.io/v2/homebrew/core/libomp/blobs/sha256:45a5aa653bd45bd5ff5858580b1a4670c4b5a51ea29d68d45a53f72f56010e05
-          brew install -f libomp-11.1.0.catalina.bottle.tar.gz
           ccache -M 2G  # See .github/workflows/readme.md for ccache strategy.
 
       - name: Config and build wheel
@@ -227,17 +304,97 @@ jobs:
           gsutil cp build/lib/python_package/pip_package/${{ env.PIP_PKG_NAME }} gs://open3d-releases/python-wheels/
           echo "Download pip package at: https://storage.googleapis.com/open3d-releases/python-wheels/${{ env.PIP_PKG_NAME }}"
 
+  fuse-wheel:
+    name: Fuse universal2 wheel
+    runs-on: [macos-12]
+    needs: [build-wheel]
+    strategy:
+      fail-fast: false
+      # https://github.community/t/how-to-conditionally-include-exclude-items-in-matrix-eg-based-on-branch/16853/6
+      matrix:
+        python_version: ['3.10', '3.11']
+        is_main:
+          - ${{ github.ref == 'refs/heads/main' }}
+        exclude:
+          - is_main: false
+            python_version: '3.10'
+    steps:
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python_version }}
+      - name: Download X64 wheels
+        uses: actions/download-artifact@v4
+        with:
+          pattern: open3d-*macosx*_x86_64.whl
+          path: x64_wheels
+          merge-multiple: true
+      - name: Download ARM64 wheels
+        uses: actions/download-artifact@v4
+        with:
+          pattern: open3d-*macosx*_arm64.whl
+          path: arm64_wheels
+          merge-multiple: true
+      - name: Fuse x64 and ARM64 wheels
+        env:
+          python_version: ${{ matrix.python_version }}
+        run: |
+          PYTAG="-cp$(echo ${{ env.python_version }} | tr -d '.')"
+          mkdir universal_wheels
+          
+          pip install delocate
+          delocate-fuse -v x64_wheels/open3d-*${PYTAG}*.whl arm64_wheels/open3d-*${PYTAG}*.whl
+
+          # Normalize file name as delocate-fuse doesn't update it
+          OLD_WHL_NAME=$(basename x64_wheels/open3d-*${PYTAG}*.whl)
+          NEW_WHL_NAME=${OLD_WHL_NAME/x86_64/universal2}
+          mv x64_wheels/${OLD_WHL_NAME} universal_wheels/${NEW_WHL_NAME}
+
+          echo "PIP_PKG_NAME=$NEW_WHL_NAME" >> $GITHUB_ENV
+      - name: Upload merged wheels
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ env.PIP_PKG_NAME }}
+          path: universal_wheels/${{ env.PIP_PKG_NAME }}
+          if-no-files-found: error
+
+      - name: GCloud CLI auth
+        if: ${{ github.ref == 'refs/heads/main' }}
+        uses: 'google-github-actions/auth@v2'
+        with:
+          project_id: ${{ secrets.GCE_PROJECT }}
+          credentials_json: '${{ secrets.GCE_SA_KEY_GPU_CI }}'
+      - name: GCloud CLI setup
+        if: ${{ github.ref == 'refs/heads/main' }}
+        uses: google-github-actions/setup-gcloud@v2
+        with:
+          version: ${{ env.GCE_CLI_GHA_VERSION }}
+          project_id: ${{ secrets.GCE_PROJECT }}
+
+      - name: Upload wheel to GCS bucket
+        if: ${{ github.ref == 'refs/heads/main' }}
+        env:
+          python_version: ${{ matrix.python_version }}
+        run: |
+          gsutil cp universal_wheels/${{ env.PIP_PKG_NAME }} gs://open3d-releases/python-wheels/
+          echo "Download pip package at: https://storage.googleapis.com/open3d-releases/python-wheels/${{ env.PIP_PKG_NAME }}"
+        
   test-wheel:
     name: Test wheel
-    runs-on: macos-12
+    runs-on: ${{ matrix.os }}
     needs: [build-wheel]
     strategy:
       fail-fast: false
       matrix:
+        os: [macos-12, macos-14]
         python_version: ['3.8', '3.9', '3.10', '3.11']
         is_main:
           - ${{ github.ref == 'refs/heads/main' }}
         exclude:
+          - os: macos-14
+            python_version: '3.8'
+          - os: macos-14
+            python_version: '3.9'
           - is_main: false
             python_version: '3.8'
           - is_main: false
@@ -273,7 +430,7 @@ jobs:
           python -V
           source util/ci_utils.sh
           pi_tag=$(python -c "import sys; print(f'cp{sys.version_info.major}{sys.version_info.minor}')")
-          test_wheel open3d*-"$pi_tag"-*.whl
+          test_wheel open3d*-"$pi_tag"-*_$(uname -m).whl
 
       - name: Run Python unit tests (benchmarks)
         run: |
@@ -286,7 +443,7 @@ jobs:
     # no need to run on macOS
     runs-on: ubuntu-latest
     if: ${{ github.ref == 'refs/heads/main' }}
-    needs: [build-wheel, MacOS]
+    needs: [fuse-wheel, MacOS]
     steps:
       - name: GCloud CLI auth
         uses: 'google-github-actions/auth@v2'

diff --git a/.github/workflows/ubuntu-cuda.yml b/.github/workflows/ubuntu-cuda.yml
@@ -152,7 +152,7 @@ jobs:
         if: ${{ env.BUILD_PACKAGE == 'true' }}
         uses: actions/upload-artifact@v4
         with:
-          name: open3d-devel-linux-x86_64-cuda-${CI_CONFIG}
+          name: open3d-devel-linux-x86_64-cuda-${{ matrix.CI_CONFIG }}
           path: open3d-devel-linux*.tar.xz
           if-no-files-found: error
 

diff --git a/3rdparty/embree/embree.cmake b/3rdparty/embree/embree.cmake
@@ -8,13 +8,11 @@ include(ExternalProject)
 # select ISAs
 if(APPLE)
     if(APPLE_AARCH64)
-        # Turn off ISA optimizations for Apple ARM64 for now.
-        set(ISA_ARGS -DEMBREE_ISA_AVX=OFF
-                     -DEMBREE_ISA_AVX2=OFF
-                     -DEMBREE_ISA_AVX512=OFF
-                     -DEMBREE_ISA_SSE2=OFF
-                     -DEMBREE_ISA_SSE42=OFF
+        set(ISA_ARGS -DEMBREE_ISA_NEON=OFF
+                     -DEMBREE_ISA_NEON2X=ON
         )
+        set(ISA_LIBS embree_avx2)
+        set(ISA_BUILD_BYPRODUCTS "<INSTALL_DIR>/${Open3D_INSTALL_LIB_DIR}/${CMAKE_STATIC_LIBRARY_PREFIX}embree_avx2${CMAKE_STATIC_LIBRARY_SUFFIX}")
     else()
         # With AppleClang we can select only 1 ISA.
         set(ISA_ARGS -DEMBREE_ISA_AVX=OFF

diff --git a/3rdparty/filament/filament_build.cmake b/3rdparty/filament/filament_build.cmake
@@ -72,5 +72,6 @@ ExternalProject_Add(
         -DFILAMENT_SUPPORTS_VULKAN=OFF
         -DFILAMENT_SKIP_SAMPLES=ON
         -DFILAMENT_OPENGL_HANDLE_ARENA_SIZE_IN_MB=20 # to support many small entities
+        -DSPIRV_WERROR=OFF
     BUILD_BYPRODUCTS ${lib_byproducts}
 )
diff --git a/3rdparty/filament/filament_download.cmake b/3rdparty/filament/filament_download.cmake
@@ -26,9 +26,17 @@ else()
             string(APPEND lib_dir /x86_64/md)
         endif()
     elseif(APPLE)
-        set(FILAMENT_URL https://github.com/google/filament/releases/download/v1.9.19/filament-v1.9.19-mac.tgz)
-        set(FILAMENT_SHA256 2765d0ce60647fc17d1880c4618cf7d6b5343d8be4dad87978c3917d9c723b4e)
-        string(APPEND lib_dir /x86_64)
+        if (APPLE_AARCH64)
+            set(FILAMENT_URL https://github.com/isl-org/open3d_downloads/releases/download/filament/filament-v1.9.19-macos_arm64.tgz)
+            set(FILAMENT_SHA256 3422bdff451d90144fbb69e625d8dcaeaf3222dc2c28879536067937955bc362)
+            string(APPEND lib_dir /arm64)
+            # Our arm64 builds use FILAMENT_SUPPORTS_VULKAN=OFF
+            list(REMOVE_ITEM filament_LIBRARIES bluevk)
+        else()
+            set(FILAMENT_URL https://github.com/google/filament/releases/download/v1.9.19/filament-v1.9.19-mac.tgz)
+            set(FILAMENT_SHA256 2765d0ce60647fc17d1880c4618cf7d6b5343d8be4dad87978c3917d9c723b4e)
+            string(APPEND lib_dir /x86_64)
+        endif()
     else()      # Linux: Check glibc version and use open3d filament binary if new (Ubuntu 20.04 and similar)
         execute_process(COMMAND ldd --version OUTPUT_VARIABLE ldd_version)
         string(REGEX MATCH "([0-9]+\.)+[0-9]+" glibc_version ${ldd_version})

diff --git a/3rdparty/librealsense/fix-macos-arm64.patch b/3rdparty/librealsense/fix-macos-arm64.patch
@@ -0,0 +1,22 @@
+From beb4c44debc8336de991c983274cad841eb5c323 Mon Sep 17 00:00:00 2001
+From: Pavol Rusnak <[email protected]>
+Date: Sun, 20 Jun 2021 12:26:58 +0200
+Subject: [PATCH] Fix build on macOS arm64
+
+---
+ src/proc/color-formats-converter.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/proc/color-formats-converter.cpp b/src/proc/color-formats-converter.cpp
+index 564a23d9c4..6c6c8c97d8 100644
+--- a/src/proc/color-formats-converter.cpp
++++ b/src/proc/color-formats-converter.cpp
+@@ -18,7 +18,7 @@
+ #include <tmmintrin.h> // For SSSE3 intrinsics
+ #endif
+
+-#if defined (ANDROID) || (defined (__linux__) && !defined (__x86_64__))
++#if defined (ANDROID) || (defined (__linux__) && !defined (__x86_64__)) || (defined (__APPLE__) && !defined (__x86_64__))
+
+ bool has_avx() { return false; }
+
diff --git a/3rdparty/librealsense/librealsense.cmake b/3rdparty/librealsense/librealsense.cmake
@@ -17,6 +17,9 @@ ExternalProject_Add(
     COMMAND ${GIT_EXECUTABLE} init
     COMMAND ${GIT_EXECUTABLE} apply --ignore-space-change --ignore-whitespace
         ${CMAKE_CURRENT_LIST_DIR}/fix-cudacrt.patch
+    # Patch for macOS ARM64 support for versions < 2.50.0
+    COMMAND ${GIT_EXECUTABLE} apply --ignore-space-change --ignore-whitespace
+        ${CMAKE_CURRENT_LIST_DIR}/fix-macos-arm64.patch
     CMAKE_ARGS
         -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>
         -DBUILD_SHARED_LIBS=OFF