support FileDialog::Mode::OPEN_DIR for selecting a directory #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
@forrestjgq Would you please comment on what the use case is for this PR? |
|
Currently OPEN and SAVE mode of FileDialog select a file path like /path/to/file.json, there is no way to select a directory path like /path/to/dir/path. OPEN_DIR mode is used to select an existing directory path. |
errissa
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @forrestjgq)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add OPEN_DIR besides OPEN and SAVE for FileDialog mode definition to select a directory in cpp as long as python.
Currently OPEN and SAVE mode of FileDialog select a file path like /path/to/file.json, there is no way to select a directory path like /path/to/dir/path. OPEN_DIR mode is used to select an existing directory path.
This change is