Add support for python3.11 #6288

OlivierLDff · 2023-07-28T15:12:08Z

Type

Bug fix (non-breaking change which fixes an issue): Fixes #
New feature (non-breaking change which adds functionality). Resolves #
Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Fix #5620

Checklist:

I have run python util/check_style.py --apply to apply Open3D code style
to my code.
This PR changes Open3D behavior or adds new functionality.
- Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
  updated accordingly.
- I have added or updated C++ and / or Python unit tests OR included test
  results (e.g. screenshots or numbers) here.
I will follow up and update the code if CI fails.
For fork PRs, I have selected Allow edits from maintainers.

Description

Update the linux/mac/windows CI to handle python 3.11
Update pybind11

I guess some documentation will also be required to be updated somewhere. I am not familiar with the workspace, I just happened to have python3.11 on my machine so wanted to give a go to the update. Maybe there more stuff to update than what I did. Let's see what the CI have to say.

Companion Open3D-ML PR: isl-org/Open3D-ML#619

This change is

update-docs · 2023-07-28T15:12:16Z

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

ssheorey · 2023-08-09T15:13:42Z

Hi @OlivierLDff thanks for this PR! There is some background info and more tasks required for this PR. The reason we were hesitating with adding Python 3.11 support is an incompatibility between PyTorch and Tensorflow dependencies, that we would also need to update. But I think we can bite the bullet and proceed now. Here are the details:

Python 3.11 is supported by TF 2.12+ and PyTorch 2.0+ only.
PyTorch still uses the old CXX11_ABI in Linux (issue), while TF switched to the new CXX11_ABI since 2.9.
We need to pick one CXX11_ABI for Open3D - we have been using the old CXX11_ABI till now and we should continue that till PyTorch also supports the new ABI. Unfortunately, this means temporarily dropping support for TensorFlow.

As a result, please make these additional changes in this PR for proper Python 3.11 support:

Update PyTorch to version 2.0.1 that supports Python 3.11
Comment out tensorflow dependencies from requirements files. Update the CI to not install / build with tensorflow.

We can also drop support for Python 3.7 in the same PR. Python 3.7 is now EOL.

Also, we need to keep the companion Open3D-ML repo in sync - we will need a companion PR for that repo. Let me know if you want some help in preparing a PR for that.

OlivierLDff · 2023-08-09T15:17:26Z

Ok thanks for the guidance. I'm currently away from any computer for a week, but I will continue this PR next week!
It doesn't seems urgent to update ATM. But if someone wants/need to finalize this this week do not hesitate to superseed this PR.
Have a nice, I will com back with more questions if required when I will get back to it.

To drop python 3.7 is there more than the file I already touched?

OlivierLDff · 2023-08-16T07:36:56Z

Coming back to this PR I now realize it might be harder than what I was expecting, since I'm not familiar with the codebase.

I guess pytorch version has to be updated there:

Open3D/util/ci_utils.sh

Lines 45 to 50 in 1012819

    
           TORCH_CPU_GLNX_VER="1.13.1+cpu" 
        
           TORCH_CUDA_GLNX_VER="1.13.1+cu116" 
        
           PYTHON_VER=$(python -c 'import sys; ver=f"{sys.version_info.major}{sys.version_info.minor}"; print(f"cp{ver}-cp{ver}{sys.abiflags}")' 2>/dev/null || true) 
        
           # TORCH_CUDA_GLNX_URL="https://github.com/isl-org/open3d_downloads/releases/download/torch1.8.2/torch-1.8.2-${PYTHON_VER}-linux_x86_64.whl" 
        
           TORCH_MACOS_VER="1.13.1" 
        
           TORCH_REPO_URL="https://download.pytorch.org/whl/torch/"

But then should cuda version be updated too?

Open3D/util/ci_utils.sh

Lines 30 to 33 in 1012819

    
           CUDA_VERSION=("11-6" "11.6") 
        
           CUDNN_MAJOR_VERSION=8 
        
           CUDNN_VERSION="8.4.1.50_cuda11.6" 
        
           GCC_MAX_VER=9

11.7 or 11.8 ?

For tensorflow, should it just be commented here:

Open3D/.github/workflows/ubuntu.yml

Line 38 in 1012819

BUILD_TENSORFLOW_OPS: ${{ matrix.MLOPS }}

ssheorey · 2023-08-17T03:38:49Z

Coming back to this PR I now realize it might be harder than what I was expecting, since I'm not familiar with the codebase.

No worries, we'll help as much as required. Thanks for working on this task!

I guess pytorch version has to be updated there:

Open3D/util/ci_utils.sh

Lines 45 to 50 in 1012819

TORCH_CPU_GLNX_VER="1.13.1+cpu"

TORCH_CUDA_GLNX_VER="1.13.1+cu116"

PYTHON_VER=$(python -c 'import sys; ver=f"{sys.version_info.major}{sys.version_info.minor}"; print(f"cp{ver}-cp{ver}{sys.abiflags}")' 2>/dev/null || true)

# TORCH_CUDA_GLNX_URL="https://github.com/isl-org/open3d_downloads/releases/download/torch1.8.2/torch-1.8.2-${PYTHON_VER}-linux_x86_64.whl"

TORCH_MACOS_VER="1.13.1"

TORCH_REPO_URL="https://download.pytorch.org/whl/torch/"

Yes.

But then should cuda version be updated too?

Open3D/util/ci_utils.sh

Lines 30 to 33 in 1012819

CUDA_VERSION=("11-6" "11.6")

CUDNN_MAJOR_VERSION=8

CUDNN_VERSION="8.4.1.50_cuda11.6"

GCC_MAX_VER=9

11.7 or 11.8 ?

Update CUDA to the oldest supported by our target PyTorch version. For 2.0, this is 11.7. Update this and the corresponding cuDNN version in all dockerfiles in the docker folder.

For tensorflow, should it just be commented here:

Open3D/.github/workflows/ubuntu.yml

Line 38 in 1012819

BUILD_TENSORFLOW_OPS: ${{ matrix.MLOPS }}

This needs to be changed in a few different places (Linux CI is all in docker):

docker/Dockerfile.wheel is used to build the Open3D wheel. Set this to OFF here:

Open3D/docker/Dockerfile.wheel

Line 128 in 1012819

&& export BUILD_TENSORFLOW_OPS=ON \
Disable TF for various CI configurations. These are all run in docker controlled by the file: docker/docker_build.sh Turn all of them OFF there and a comment such as OFF due to cxx11_abi to each one.
Finally, in ubuntu.yml, the BUILD_TENSORFLOW_OPS and BUILD_PYTORCH_OPS settings are unused (leftovers from earlier changes). Go ahead and delete them.

We provide both cxx11_abi and pre cxx11_abi C++ binary builds for Open3D, so it is possible to support TF through C++. However, for simplicity, lets disable it completely in Linux.

For macOS, the ABI is not a problem. Lets upgrade Tensorflow to the latest there (2.12). This ensures that our TF code continues to be maintained. This will also need changes to util/ci_utils.sh (near where you update the PyTorch version).

OlivierLDff · 2023-08-17T06:16:19Z

Would it be possible to approve workflow run so I can see what is working/failing?

OlivierLDff · 2023-08-17T06:17:36Z

Forget what I said, it seems everything is working when I PR against my own repo

- Update the linux/mac/windows CI to handle python 3.11

…TORCH_OPS

OlivierLDff · 2023-08-17T12:07:58Z

Ok so I updated a bunch of stuff, they are kept in different commit for easier review/understanding of what I did.
I'm running into multiple issues and I would gladly receive some insight before investing some times.

MacOS

tensorflow framework

So it seems tensorflow framework is no longer available, but I'm not familiar with that library. I just commented out things in the CMakeLists to ignore that for now. I guess this is the kind of issue that will blow up at linking time, that I haven't reached yet.

e55988b

Do you have any insight if the tensorflow_framework disappeared? Couldn't find anything, but didn't look for long.

Macos min version

It seems that min macos version is 10.15, but I'm running into issues with tensorflow

that don't include the right header (for example #include <optional> and stuff.
libusb was compiled with min version 12.x.

You can checks logs here: https://github.com/OlivierLDff/Open3D/actions/runs/5889809346/job/15973684524?pr=1

I guess by updating min macos version to 12.x, things will go away. Is it something you wish to do?

Open3D/3rdparty/vtk/CMakeLists.txt

Lines 33 to 35 in c7718fd

    
           set (CMAKE_OSX_DEPLOYMENT_TARGET "10.15" CACHE STRING 
        
               "Minimum OS X deployment version" FORCE) 
        
           endif()

Ubuntu

Tensorflow

I have this really strange error:

Downloading tensorflow-gpu-2.12.0.tar.gz (2.6 kB)
#24 35.23     ERROR: Command errored out with exit status 1:
#24 35.23      command: /root/miniconda3/envs/open3d/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-dp_5t5al/tensorflow-gpu_22a7e4fc178b45c3a700cbb994608eb0/setup.py'"'"'; __file__='"'"'/tmp/pip-install-dp_5t5al/tensorflow-gpu_22a7e4fc178b45c3a700cbb994608eb0/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-rhpu13wg
#24 35.23          cwd: /tmp/pip-install-dp_5t5al/tensorflow-gpu_22a7e4fc178b45c3a700cbb994608eb0/
#24 35.23     Complete output (38 lines):
#24 35.23     Traceback (most recent call last):
#24 35.23       File "/root/miniconda3/envs/open3d/lib/python3.10/site-packages/setuptools/_vendor/packaging/requirements.py", line 35, in __init__
#24 35.23         parsed = parse_requirement(requirement_string)
#24 35.23       File "/root/miniconda3/envs/open3d/lib/python3.10/site-packages/setuptools/_vendor/packaging/_parser.py", line 64, in parse_requirement
#24 35.23         return _parse_requirement(Tokenizer(source, rules=DEFAULT_RULES))
#24 35.23       File "/root/miniconda3/envs/open3d/lib/python3.10/site-packages/setuptools/_vendor/packaging/_parser.py", line 82, in _parse_requirement
#24 35.23         url, specifier, marker = _parse_requirement_details(tokenizer)
#24 35.23       File "/root/miniconda3/envs/open3d/lib/python3.10/site-packages/setuptools/_vendor/packaging/_parser.py", line 126, in _parse_requirement_details
#24 35.23         marker = _parse_requirement_marker(
#24 35.23       File "/root/miniconda3/envs/open3d/lib/python3.10/site-packages/setuptools/_vendor/packaging/_parser.py", line 147, in _parse_requirement_marker
#24 35.23         tokenizer.raise_syntax_error(
#24 35.23       File "/root/miniconda3/envs/open3d/lib/python3.10/site-packages/setuptools/_vendor/packaging/_tokenizer.py", line 163, in raise_syntax_error
#24 35.23         raise ParserSyntaxError(
#24 35.23     setuptools.extern.packaging._tokenizer.ParserSyntaxError: Expected end or semicolon (after name and no valid version specifier)
#24 35.23         python_version>"3.7"

I'm not sure where is it coming from or how to track that. This seems to come from tensorflow which is anyway not in used. Have you ever heard of this problem?

Headless docs (ubuntu)

I'm running in a missing symbol, but this seems to be because I'm using the wrong repo for open3d-ML

Traceback (most recent call last):
  File "generate_tf_ops_wrapper.py", line 110, in <module>
    sys.exit(main())
  File "generate_tf_ops_wrapper.py", line 61, in main
    oplib = tf.load_op_library(args.lib)
  File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/tensorflow/python/framework/load_library.py", line 54, in load_op_library
    lib_handle = py_tf.TF_LoadLibrary(library_filename)
tensorflow.python.framework.errors_impl.NotFoundError: /home/runner/work/Open3D/Open3D/build/lib/Release/cpu/open3d_tf_ops.so: undefined symbol: _ZTIN10tensorflow8OpKernelE

https://github.com/OlivierLDff/Open3D/actions/runs/5889809363/job/15973675060?pr=1

This also require protobuf to be updated to 3.24.0

This is possible because - tensorflow support is temporarily dropped - pytorch got updated to 2.0.1

ssheorey · 2023-10-13T04:26:42Z

Looks like build is failing due to this line? https://github.com/isl-org/Open3D/actions/runs/6399541003/job/17371755134?pr=6288#step:4:13726
#29 2234.8 make: *** No rule to make target 'open3d_tf_ops'.  Stop.
Probably need to guard these make targets behind the env var

Open3D/util/ci_utils.sh

Line 198 in c61fb71

make VERBOSE=1 -j"$NPROC" pybind open3d_tf_ops open3d_torch_ops

Thanks @igozali you have sharp eyes...

johnthagen · 2023-10-13T14:36:24Z

@ssheorey In case it helps, I noticed that Pytorch recently uploaded cpu.cxx11.abi wheels to their custom wheel repo:

https://download.pytorch.org/whl/torch/

For example:

https://download.pytorch.org/whl/cpu-cxx11-abi/torch-2.1.0%2Bcpu.cxx11.abi-cp311-cp311-linux_x86_64.whl#sha256=0aafe9ff268e209831d38acd3e0b39a95ae76ff45a88ec0e48d7019cf476dc21

Enable users to build wheel with tfops locally with docker container.

ssheorey · 2023-10-13T18:16:00Z

@ssheorey In case it helps, I noticed that Pytorch recently uploaded cpu.cxx11.abi wheels to their custom wheel repo:
* https://download.pytorch.org/whl/torch/
For example:
* https://download.pytorch.org/whl/cpu-cxx11-abi/torch-2.1.0%2Bcpu.cxx11.abi-cp311-cp311-linux_x86_64.whl#sha256=0aafe9ff268e209831d38acd3e0b39a95ae76ff45a88ec0e48d7019cf476dc21

Thanks, that is useful. Hope they finish the migration to the new cxx11_abi quickly. To keep a handle on complexity, we'll go with the old cxx11_abi for now and without tf ops on Linux. We'll switch completely to the new cxx11_abi with both torch and tf in a future PR.

I'll add instructions for users to build an Open3D wheel with tf ops and the new cxx11_abi in the meantime.

benjaminum

Reviewable status: 0 of 39 files reviewed, all discussions resolved

johnthagen · 2023-10-24T10:08:09Z

@ssheorey I was curious if the team was planning a 0.18 release to support Python 3.11? We are excited to try it out. ❤️

ssheorey · 2023-10-24T15:55:43Z

Yes, we will have a 0.18 release soon. :-)

Companion Open3D PR: isl-org/Open3D#6288 - Add support for python3.11. -️ Upgrade pytorch to 2.0.1 with cuda 11.7 - Upgrade tensorflow / tensorboard to 2.13. - Disable building tensorflow ops on Linux. Keep old cxx11_abi. - Update CI to use requirements files instead of manually specified versions. - Add instructions to build with new cxx11_abi with tensorflow ops support.

thomasegriffith · 2023-10-27T19:17:15Z

Yes, we will have a 0.18 release soon. :-)

Really looking forward to this! Do you have a rough idea on the timeline?

thomasegriffith · 2023-11-07T18:21:42Z

@ssheorey any idea when the 0.18 release will happen? TIA!

sharon-br · 2023-11-29T11:41:53Z

@ssheorey Any updates on the 0.18 release?

johnthagen · 2023-12-13T13:11:59Z

♫ All I want for Christmas is a new Open3D ♬

😄 ❤️

ssheorey · 2023-12-29T07:14:19Z

♫ All I want for Christmas is a new Open3D ♬

😄 ❤️

Working on it... Hope to have a new year present for all...

johnthagen · 2024-01-05T02:16:37Z

It's out 🚀

OlivierLDff force-pushed the support-python-311 branch from 1a0f81e to 2b1e5d6 Compare July 28, 2023 15:23

OlivierLDff marked this pull request as ready for review July 31, 2023 07:39

ssheorey self-requested a review August 9, 2023 04:04

OlivierLDff added 2 commits August 17, 2023 09:01

Add support for python3.11

a6cab5b

- Update the linux/mac/windows CI to handle python 3.11

️upgrade pytorch to 2.0.1 with cuda 11.7 in ci_utils

95ed4d1

OlivierLDff force-pushed the support-python-311 branch 2 times, most recently from 02fd1bc to 36531b4 Compare August 17, 2023 07:15

OlivierLDff added 2 commits August 17, 2023 09:21

ci(linux): introduce python 3.11 in docker tests script

32a1f1e

ci(linux): delete unused env variable BUILD_TENSORFLOW_OPS & BUILD_PY…

8f7b138

…TORCH_OPS

OlivierLDff force-pushed the support-python-311 branch 8 times, most recently from e55988b to 41ab5a0 Compare August 17, 2023 12:07

OlivierLDff added 5 commits August 17, 2023 14:35

ci: upgrade tensorflow to 2.12.0 & tensorboard to 2.14.0

03e3392

This also require protobuf to be updated to 3.24.0

ci(linux): disable tensorflow build, due to cxx abi issue

d892962

ci(linux): always use cxx11_abi

a5c2c66

This is possible because - tensorflow support is temporarily dropped - pytorch got updated to 2.0.1

drop support for python3.7

f8db0bd

temp commit to test open3d-ml update

83a2f41

ssheorey requested a review from benjaminum October 13, 2023 05:09

ssheorey mentioned this pull request Oct 13, 2023

Support python 311 isl-org/Open3D-ML#619

Merged

Move BUILD_TF/TORCH_OPS settings to github actions file

52206a5

Enable users to build wheel with tfops locally with docker container.

Set cxx11_abi based on tf / torch ops in ci_utls.sh

8af2f8f

ssheorey approved these changes Oct 17, 2023

View reviewed changes

johnthagen mentioned this pull request Oct 17, 2023

Support Python 3.12 #6433

Closed

3 tasks

benjaminum approved these changes Oct 23, 2023

View reviewed changes

ssheorey force-pushed the support-python-311 branch from efd57da to 8af2f8f Compare October 23, 2023 18:47

ssheorey merged commit a2401d0 into isl-org:master Oct 23, 2023
62 of 65 checks passed

This was referenced Nov 20, 2023

Support for Python Optional Dependencies #5853

Open

0.17.0 install problem #6490

Open

monajalal mentioned this pull request Nov 27, 2023

need open3d for Python 3.11 #6510

Closed

3 tasks

johnthagen mentioned this pull request Dec 16, 2023

Update supported Python versions (PyPI) in readme #6536

Closed

shoaibahmed mentioned this pull request Dec 28, 2023

Cannot install Open3D Python library when building from source (Pytorch 2.1.0+cu121 & Python 3.10) #6552

Open

3 tasks

This was referenced Jan 5, 2024

Request to add Python 3.11 support? #5620

Closed

Cant install the library. #6346

Closed

Could not find a version that satisfies the requirement open3d, no pip for Python 3.11? #6145

Open

swheaton mentioned this pull request Mar 25, 2024

Support python 312 #6717

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for python3.11 #6288

Add support for python3.11 #6288

OlivierLDff commented Jul 28, 2023 •

edited by ssheorey

Loading

update-docs bot commented Jul 28, 2023

ssheorey commented Aug 9, 2023

OlivierLDff commented Aug 9, 2023

OlivierLDff commented Aug 16, 2023

ssheorey commented Aug 17, 2023

OlivierLDff commented Aug 17, 2023

OlivierLDff commented Aug 17, 2023

OlivierLDff commented Aug 17, 2023

ssheorey commented Oct 13, 2023

johnthagen commented Oct 13, 2023

ssheorey commented Oct 13, 2023

benjaminum left a comment

johnthagen commented Oct 24, 2023

ssheorey commented Oct 24, 2023

thomasegriffith commented Oct 27, 2023

thomasegriffith commented Nov 7, 2023

sharon-br commented Nov 29, 2023

johnthagen commented Dec 13, 2023

ssheorey commented Dec 29, 2023

johnthagen commented Jan 5, 2024 •

edited

Loading

Add support for python3.11 #6288

Add support for python3.11 #6288

Conversation

OlivierLDff commented Jul 28, 2023 • edited by ssheorey Loading

Type

Motivation and Context

Checklist:

Description

update-docs bot commented Jul 28, 2023

ssheorey commented Aug 9, 2023

OlivierLDff commented Aug 9, 2023

OlivierLDff commented Aug 16, 2023

ssheorey commented Aug 17, 2023

OlivierLDff commented Aug 17, 2023

OlivierLDff commented Aug 17, 2023

OlivierLDff commented Aug 17, 2023

MacOS

tensorflow framework

Macos min version

Ubuntu

Tensorflow

Headless docs (ubuntu)

ssheorey commented Oct 13, 2023

johnthagen commented Oct 13, 2023

ssheorey commented Oct 13, 2023

benjaminum left a comment

Choose a reason for hiding this comment

johnthagen commented Oct 24, 2023

ssheorey commented Oct 24, 2023

thomasegriffith commented Oct 27, 2023

thomasegriffith commented Nov 7, 2023

sharon-br commented Nov 29, 2023

johnthagen commented Dec 13, 2023

ssheorey commented Dec 29, 2023

johnthagen commented Jan 5, 2024 • edited Loading

OlivierLDff commented Jul 28, 2023 •

edited by ssheorey

Loading

johnthagen commented Jan 5, 2024 •

edited

Loading