Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes for v0.18 #6562

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Build fixes for v0.18 #6562

merged 4 commits into from
Jan 4, 2024

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Jan 2, 2024

  • Debian viewer package paths
  • Build binary package cxx11_abi with TF
  • Update node.js install method

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Jan 2, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Update node.js install method
@ssheorey ssheorey force-pushed the ss/deb-fix branch 2 times, most recently from b9cf447 to 4164f16 Compare January 3, 2024 18:12
@ssheorey ssheorey requested review from benjaminum and errissa January 3, 2024 18:52
@ssheorey ssheorey marked this pull request as ready for review January 3, 2024 18:53
Copy link
Collaborator

@errissa errissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssheorey ssheorey merged commit bc8d4ce into main Jan 4, 2024
22 of 23 checks passed
@ssheorey ssheorey deleted the ss/deb-fix branch January 4, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants