Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for pybind11-stubgen errors #6896

Merged
merged 17 commits into from
Dec 11, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed TransformationEstimationPointToPoint.__repr__.
* It now mirrors constructor call.
timohl committed Nov 26, 2024
commit 30fcc153aa24b9a0a5823754cc400a4c9a53e753
9 changes: 4 additions & 5 deletions cpp/pybind/pipelines/registration/registration.cpp
Original file line number Diff line number Diff line change
@@ -264,11 +264,10 @@ void pybind_registration_definitions(py::module &m) {
"with_scaling"_a = false)
.def("__repr__",
[](const TransformationEstimationPointToPoint &te) {
return std::string(
"TransformationEstimationPointToPoint ") +
(te.with_scaling_
? std::string("with scaling.")
: std::string("without scaling."));
return fmt::format(
"TransformationEstimationPointToPoint("
"with_scaling={})",
te.with_scaling_ ? "True" : "False");
})
.def_readwrite(
"with_scaling",