Expose minimal oriented bounding box to python api #6946
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
I was unsure how to name the function - another option was Also, any plans on 0.19 to include this and #6898 ? |
| @@ -83,6 +83,27 @@ The returned bounding box is an approximation to the minimal bounding box. | |||
| open3d.geometry.OrientedBoundingBox: The oriented bounding box. The | |||
| bounding box is oriented such that the axes are ordered with respect to | |||
| the principal components. | |||
| )doc") | |||
| .def_static("create_minimal_from_points", | |||
There was a problem hiding this comment.
Can we name create_from_points_minimal instead so that it matches the C++ function?
There was a problem hiding this comment.
Done. Is there any timeline regarding the 0.19 release?
There was a problem hiding this comment.
As soon as we can get the Python 3.12 support PR merged. There are still some test failures blocking that.
sharon-br
deleted the
expose-minimal-oriented-bounding-box-to-python-api
branch
This PR exposes the minimal volume bounding box function to the python API.
Motivation and Context
Only the static function
create_from_pointsis currently exposed to the Python API.However, in the CPP API, another option exists which is to create a bounding box with a minimal volume that is not exposed.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description