Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when compile with native cuda arch #7059

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

USTCKAY
Copy link
Contributor

@USTCKAY USTCKAY commented Nov 18, 2024

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Fix Invalid architecture string bug when compile with native cuda arch by default, cmake error report is below:
image

Copy link

update-docs bot commented Nov 18, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@USTCKAY
Copy link
Contributor Author

USTCKAY commented Nov 18, 2024

@benjaminum @ssheorey Hi, could you please help to take a review?

@ssheorey
Copy link
Member

Hi @USTCKAY can you confirm that the changes work for you? i.e. cmake configures correctly with this change? Also what version of cmake are you using?

@USTCKAY
Copy link
Contributor Author

USTCKAY commented Nov 21, 2024

Hi @USTCKAY can you confirm that the changes work for you? i.e. cmake configures correctly with this change? Also what version of cmake are you using?

Yeah,cmake could complete and build could succeed after applying this change. My cmake version is 3.30.5, and I compiled Open3D in docker with image pytorch/pytorch:2.5.1-cuda12.1-cudnn9-devel.
image

@ssheorey ssheorey merged commit 11aa48e into isl-org:main Nov 22, 2024
35 of 39 checks passed
@USTCKAY USTCKAY deleted the fix_cmake branch December 27, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants