Changed draw_geometries to use default args instead of overload #7097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
Currently,
o3d.visualization.draw_geometries
uses overloading to provide default values forlookat
,up
,front
, andzoom
.This causes two problems:
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
This PR uses
utility::optional
to provide a single binding function (no overload) with a clean argument list.The arguments are in line with the cpp implementation (which also uses default args).
This solution avoids named args before positional args.
This is a fix used in #6917 since
mypy
would complain aboutnon-default argument follows default argument [syntax]
.