feat(endorsement-system): Store ownername (#17248)

* ownername db and logic * chore: nx format:write update dirty files * tweaks * chore: nx format:write update dirty files * Empty commit for triggering CI/CD * db check fallback * Empty commit for triggering CI/CD * Empty commit for triggering CI/CD --------- Co-authored-by: andes-it <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
island-is · Dec 17, 2024 · b280879 · b280879
1 parent 980afb0
commit b280879
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 1 deletion.
diff --git a/apps/services/endorsements/api/migrations/20241216113500-add-ownerName-column.js b/apps/services/endorsements/api/migrations/20241216113500-add-ownerName-column.js
@@ -0,0 +1,12 @@
+module.exports = {
+  up: async (queryInterface, Sequelize) => {
+    await queryInterface.addColumn('endorsement_list', 'owner_name', {
+      type: Sequelize.STRING,
+      allowNull: true,
+    })
+  },
+
+  down: async (queryInterface, Sequelize) => {
+    await queryInterface.removeColumn('endorsement_list', 'owner_name')
+  },
+}
diff --git a/apps/services/endorsements/api/src/app/modules/endorsementList/endorsementList.model.ts b/apps/services/endorsements/api/src/app/modules/endorsementList/endorsementList.model.ts
@@ -85,6 +85,13 @@ export class EndorsementList extends Model {
   })
   owner!: string
 
+  @ApiProperty()
+  @Column({
+    type: DataType.STRING,
+    allowNull: true,
+  })
+  ownerName?: string
+
   @ApiProperty()
   @Column({
     type: DataType.BOOLEAN,

diff --git a/apps/services/endorsements/api/src/app/modules/endorsementList/endorsementList.service.ts b/apps/services/endorsements/api/src/app/modules/endorsementList/endorsementList.service.ts
@@ -247,7 +247,11 @@ export class EndorsementListService {
       ])
     }
     this.logger.info(`Creating endorsement list: ${list.title}`)
-    const endorsementList = await this.endorsementListModel.create({ ...list })
+    const ownerName = await this.fetchOwnerNameFromRegistry(list.owner)
+    const endorsementList = await this.endorsementListModel.create({
+      ...list,
+      ownerName,
+    })
 
     if (process.env.NODE_ENV === 'production') {
       await this.emailCreated(endorsementList)
@@ -305,6 +309,10 @@ export class EndorsementListService {
         throw new NotFoundException(['This endorsement list does not exist.'])
       }
       owner = endorsementList.owner
+      // Use stored ownerName if available
+      if (endorsementList.ownerName) {
+        return endorsementList.ownerName
+      }
     }
 
     try {
@@ -953,4 +961,19 @@ export class EndorsementListService {
       )
     }
   }
+
+  private async fetchOwnerNameFromRegistry(
+    nationalId: string,
+  ): Promise<string> {
+    try {
+      const person = await this.nationalRegistryApiV3.getName(nationalId)
+      return person?.fulltNafn ? person.fulltNafn : ''
+    } catch (error) {
+      this.logger.error('Failed to fetch owner name from NationalRegistry', {
+        error: error.message,
+        nationalId,
+      })
+      return ''
+    }
+  }
 }