Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deployme #12418

Closed
wants to merge 30 commits into from
Closed

chore: deployme #12418

wants to merge 30 commits into from

Conversation

AndesKrrrrrrrrrrr
Copy link
Member

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr changed the title deployme chore: deployme Oct 16, 2023
@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr added the deploy-feature Deploys features to dev label Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Affected services are: air-discount-scheme-api,air-discount-scheme-backend,api,application-system-api,download-service,financial-aid-api,judicial-system-api,judicial-system-backend,license-api,regulations-admin-backend,services-auth-admin-api,services-auth-delegation-api,services-auth-ids-api,services-auth-personal-representative,services-auth-personal-representative-public,services-auth-public-api,services-endorsements-api,services-search-indexer,services-university-gateway,services-user-notification,services-user-profile,web,application-system-form,service-portal,system-e2e,

@datadog-island-is
Copy link

datadog-island-is bot commented Oct 16, 2023

Datadog Report

All test runs 26d394e 🔗

6 Total Test Services: 0 Failed, 0 with New Flaky, 6 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
judicial-system-api 0 0 0 25 0 106.84ms Link
judicial-system-backend 0 0 0 3531 0 12m 55.65s Link
judicial-system-message 0 0 0 30 0 268.62ms Link
judicial-system-types 0 0 0 35 0 161.9ms Link
judicial-system-web 0 0 0 286 1 41.08s Link
license-api 0 0 0 3 0 27.59ms Link

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.14%. Comparing base (714e7d2) to head (d4e9c95).
Report is 200 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12418   +/-   ##
=======================================
  Coverage   37.13%   37.14%           
=======================================
  Files        6373     6373           
  Lines      129702   129679   -23     
  Branches    36999    36985   -14     
=======================================
+ Hits        48161    48163    +2     
+ Misses      81541    81516   -25     
Flag Coverage Δ
air-discount-scheme-backend 53.74% <ø> (ø)
api 3.46% <ø> (ø)
api-domains-air-discount-scheme 35.86% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 57.91% <ø> (ø)
api-domains-communications 40.56% <ø> (ø)
api-domains-criminal-record 43.25% <ø> (-0.20%) ⬇️
api-domains-driving-license 44.20% <ø> (-0.06%) ⬇️
api-domains-education 33.50% <ø> (ø)
api-domains-health-insurance 27.15% <ø> (ø)
api-domains-mortgage-certificate 34.78% <ø> (ø)
api-domains-payment-schedule 40.23% <ø> (ø)
application-api-files 56.37% <ø> (ø)
application-system-api 41.96% <ø> (ø)
application-template-api-modules 24.32% <ø> (+0.01%) ⬆️
application-templates-car-recycling 4.23% <ø> (ø)
application-templates-criminal-record 21.67% <ø> (ø)
application-templates-driving-license 16.47% <ø> (ø)
application-templates-estate 11.75% <ø> (ø)
application-templates-example-payment 20.49% <ø> (ø)
application-templates-inheritance-report 3.96% <ø> (ø)
application-templates-mortgage-certificate 44.18% <ø> (ø)
application-ui-shell 21.72% <ø> (ø)
auth-api-lib 9.63% <ø> (+0.11%) ⬆️
clients-charge-fjs-v2 22.58% <ø> (ø)
clients-driving-license 40.11% <ø> (ø)
clients-driving-license-book 43.49% <ø> (-0.11%) ⬇️
clients-financial-statements-inao 48.36% <ø> (ø)
clients-license-client 1.84% <ø> (ø)
clients-middlewares 73.53% <ø> (+0.14%) ⬆️
clients-regulations 41.66% <ø> (-0.16%) ⬇️
clients-rsk-company-registry 29.24% <ø> (ø)
clients-syslumenn 49.34% <ø> (-0.38%) ⬇️
cms 0.44% <ø> (ø)
cms-translations 39.67% <ø> (ø)
download-service 44.37% <ø> (-0.13%) ⬇️
judicial-system-api 17.63% <ø> (ø)
judicial-system-backend 56.10% <ø> (ø)
license-api 43.06% <ø> (-0.03%) ⬇️
services-auth-admin-api 51.96% <ø> (-0.04%) ⬇️
services-auth-delegation-api 61.76% <ø> (-0.03%) ⬇️
services-auth-ids-api 54.17% <ø> (+0.01%) ⬆️
services-auth-personal-representative 48.56% <ø> (ø)
services-auth-personal-representative-public 44.30% <ø> (ø)
services-auth-public-api 49.80% <ø> (ø)
services-endorsements-api 55.19% <ø> (ø)
services-university-gateway 48.42% <ø> (+0.14%) ⬆️
services-user-notification 47.57% <ø> (ø)
services-user-profile 62.71% <ø> (ø)
web 1.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apps/api/src/main.ts 0.00% <ø> (ø)
apps/services/license-api/src/app/app.module.ts 100.00% <ø> (ø)
apps/web/server.ts 0.00% <ø> (ø)
.../clients/middlewares/src/lib/withCircuitBreaker.ts 60.00% <ø> (-33.34%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714e7d2...d4e9c95. Read the comment docs.

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr added deploy-feature Deploys features to dev and removed deploy-feature Deploys features to dev labels Oct 30, 2023
@andes-it
Copy link
Member

This PR's had a 15-day siesta. Lost its spark, did it? It's making an exit in 5 days unless the stale label disappears.

@andes-it andes-it added the stale Issue or pull request is stale label Nov 15, 2023
@andes-it
Copy link
Member

This PR closed its doors. Sat around for a day after the stale tag, then reckoned it's not worth the fuss.

Copy link
Contributor

coderabbitai bot commented Apr 26, 2024

Important

Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tip

Early Access Features
  • gpt-4o model for chat

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@datadog-island-is
Copy link

datadog-island-is bot commented Apr 26, 2024

Datadog Report

All test runs 22b4ab9 🔗

46 Total Test Services: 0 Failed, 45 Passed
❄️ 1 with New Flaky
🔻 Test Sessions change in coverage: 9 decreased, 7 increased, 172 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
services-auth-delegation-api 0 0 3 254 0 4m 4.93s 1 increased (+0.09%) Link
air-discount-scheme-backend 0 0 0 81 0 37.22s 1 decreased (-0.16%) Link
api 0 0 0 4 0 4.41s N/A Link
api-domains-air-discount-scheme 0 0 0 12 0 49.74s 1 no change Link
api-domains-assets 0 0 0 6 0 32.04s 1 no change Link
api-domains-auth-admin 0 0 0 36 0 39.53s 1 no change Link
api-domains-communications 0 0 0 10 0 1m 43.49s 1 no change Link
api-domains-criminal-record 0 0 0 10 0 25.36s 1 decreased (-0.22%) Link
api-domains-driving-license 0 0 0 23 0 1m 0.79s 1 decreased (-0.03%) Link
api-domains-education 0 0 0 8 0 37.33s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (9)

This report shows up to 5 code coverage decreases.

  • clients-middlewares - jest 75.81% (-0.43%) - Details
  • api-domains-criminal-record - jest 45.72% (-0.22%) - Details
  • clients-regulations - jest 44.74% (-0.17%) - Details
  • air-discount-scheme-backend - jest 51.87% (-0.16%) - Details
  • clients-driving-license-book - jest 38.86% (-0.07%) - Details

@andes-it andes-it removed the stale Issue or pull request is stale label Apr 27, 2024
@andes-it
Copy link
Member

This PR's had a 15-day siesta. Lost its spark, did it? It's making an exit in 5 days unless the stale label disappears.

@andes-it andes-it added stale Issue or pull request is stale and removed stale Issue or pull request is stale labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-feature Deploys features to dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants