-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(universities): add university clients #14075
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14075 +/- ##
==========================================
+ Coverage 36.99% 37.01% +0.01%
==========================================
Files 6265 6291 +26
Lines 127220 127585 +365
Branches 36417 36520 +103
==========================================
+ Hits 47071 47230 +159
- Misses 80149 80355 +206 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…-clients' into feat/add-university-clients
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
infra LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve the 1 file that stefna owns but have a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codeowned file LGTM
libs/api/domains/university-careers/src/lib/universityCareers.service.ts
Show resolved
Hide resolved
This PR currently has a merge conflict. Please resolve this and then re-add the |
* feat: init * feat: lhbi * fix: remove lbhi * feat: init * feat: init * feat: init * feat: generate * feat: generate * feat: generate * chore: prettier * feat: generate * feat: add service nad generate * feat: move into * feat: gen * feat: rem and gen again * fix: n again * feat: gen * feat: move * feat: rem and gen * feat: gen * feat: gen * feat: one client * fix: compatibiliy * chore: remove old * chore: charts update dirty files * feat: gen api domain * feat: add to domain * chore/update-codeowners * feat: gql finagling * fix: imports * chore: codeowners * fix: codeowenrs * chore:lint * fix: build * fix: scope * feat: change graphql model * fix: enum * fix: loading * chore: clean up * feat: detail works * fix: organization mapping * chore: nx format:write update dirty files * chore: add xroad def to infra * chore: charts update dirty files * chore: fix env name * feat: clean up intro headers * fix: module imports * fix: logos * feat: logo fix * feat: better mapping * fix: type error * chore: nx format:write update dirty files * feat: add warning screen if no transcripts * fix: remove logging import * fix: remove logging * fix: import * fix: no match * fix: update image url * chore: clean up --------- Co-authored-by: Þorkell Máni Þorkelsson <[email protected]> Co-authored-by: andes-it <[email protected]>
What
Why
Checklist: