Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(universities): add university clients #14075

Merged
merged 107 commits into from
May 7, 2024
Merged

Conversation

thorkellmani
Copy link
Member

@thorkellmani thorkellmani commented Mar 8, 2024

What

  • Add a new super client for all the involved universities
  • New generic university careers domain

Why

  • 4 new universities all using the same service as HÍ. Wasteful to make a new client for each since they're identical, so we just make a big client instead.
  • Also new api domain that's more generic.
  • new function for getting contentful organization by reference id

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 72 lines in your changes are missing coverage. Please review.

Project coverage is 37.01%. Comparing base (e8f2a0a) to head (c3e2ea6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14075      +/-   ##
==========================================
+ Coverage   36.99%   37.01%   +0.01%     
==========================================
  Files        6265     6291      +26     
  Lines      127220   127585     +365     
  Branches    36417    36520     +103     
==========================================
+ Hits        47071    47230     +159     
- Misses      80149    80355     +206     
Flag Coverage Δ
air-discount-scheme-backend 54.10% <100.00%> (+0.05%) ⬆️
api 3.44% <0.00%> (ø)
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 36.15% <100.00%> (+0.19%) ⬆️
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 56.87% <ø> (ø)
api-domains-communications 40.34% <44.44%> (+0.01%) ⬆️
api-domains-criminal-record 43.83% <ø> (ø)
api-domains-driving-license 44.77% <100.00%> (+0.09%) ⬆️
api-domains-education 33.75% <100.00%> (+0.19%) ⬆️
api-domains-payment-schedule 40.50% <100.00%> (+0.18%) ⬆️
application-api-files 56.61% <100.00%> (+0.14%) ⬆️
application-core 71.41% <ø> (-0.27%) ⬇️
application-system-api 42.08% <44.44%> (-0.04%) ⬇️
application-template-api-modules 24.64% <100.00%> (+0.02%) ⬆️
application-templates-accident-notification 19.59% <ø> (ø)
application-templates-driving-license 16.79% <ø> (ø)
application-templates-example-payment 20.39% <ø> (ø)
application-templates-financial-aid 12.23% <ø> (ø)
application-templates-general-petition 19.03% <ø> (ø)
application-templates-health-insurance 23.03% <ø> (ø)
application-templates-inheritance-report 3.89% <ø> (ø)
application-templates-mortgage-certificate 43.89% <ø> (ø)
application-types 7.43% <ø> (ø)
application-ui-components 1.44% <ø> (ø)
application-ui-shell 21.72% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-api-lib 9.93% <ø> (ø)
auth-nest-tools 29.14% <ø> (ø)
auth-react 22.97% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 22.58% <ø> (ø)
clients-driving-license-book 44.02% <100.00%> (+0.12%) ⬆️
clients-license-client 1.84% <ø> (ø)
clients-middlewares 73.96% <ø> (+0.09%) ⬆️
clients-rsk-company-registry 29.24% <ø> (-0.06%) ⬇️
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-zendesk 55.26% <ø> (ø)
cms 0.44% <0.00%> (-0.01%) ⬇️
cms-translations 39.43% <44.44%> (+0.01%) ⬆️
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.57% <ø> (ø)
contentful-apps 6.60% <ø> (ø)
download-service 44.31% <67.34%> (-0.40%) ⬇️
email-service 61.42% <ø> (ø)
file-storage 52.05% <100.00%> (+0.62%) ⬆️
financial-aid-backend 56.22% <100.00%> (+0.05%) ⬆️
icelandic-names-registry-backend 54.10% <ø> (+0.03%) ⬆️
infra-nest-server 48.33% <ø> (ø)
island-ui-core 28.69% <ø> (ø)
judicial-system-backend 55.73% <44.44%> (-0.01%) ⬇️
judicial-system-formatters 82.90% <ø> (ø)
license-api 43.23% <100.00%> (+0.06%) ⬆️
message-queue 68.39% <ø> (ø)
nest-audit 68.20% <ø> (ø)
nest-config 77.54% <100.00%> (+0.34%) ⬆️
nest-feature-flags 50.73% <100.00%> (-0.35%) ⬇️
nova-sms 63.41% <ø> (ø)
portals-admin-regulations-admin 2.13% <ø> (ø)
portals-core 16.14% <ø> (ø)
reference-backend 50.31% <ø> (ø)
regulations 16.90% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 50.65% <100.00%> (+0.02%) ⬆️
services-auth-delegation-api 62.50% <100.00%> (+0.01%) ⬆️
services-auth-ids-api 54.75% <100.00%> (-0.01%) ⬇️
services-auth-personal-representative 49.88% <100.00%> (-0.02%) ⬇️
services-auth-personal-representative-public 45.48% <100.00%> (+0.08%) ⬆️
services-auth-public-api 50.31% <100.00%> (+0.02%) ⬆️
services-user-profile 62.55% <100.00%> (+0.05%) ⬆️
shared-components 27.82% <ø> (ø)
shared-form-fields 31.91% <ø> (ø)
shared-mocking 64.62% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 27.66% <ø> (ø)
web 1.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apps/download-service/src/app/app.module.ts 100.00% <ø> (ø)
libs/clients/university-careers/src/index.ts 100.00% <100.00%> (ø)
...ulturalUniversityOfIcelandCareerClient.provider.ts 62.50% <100.00%> (ø)
...lients/agricultural-university-of-iceland/index.ts 100.00% <100.00%> (ø)
...areers/src/lib/clients/bifrost-university/index.ts 100.00% <100.00%> (ø)
...-careers/src/lib/clients/holar-university/index.ts 100.00% <100.00%> (ø)
...lients/university-careers/src/lib/clients/index.ts 100.00% <100.00%> (ø)
...rs/src/lib/clients/university-of-akureyri/index.ts 100.00% <100.00%> (ø)
...ers/src/lib/clients/university-of-iceland/index.ts 100.00% <100.00%> (ø)
...lients/university-careers/src/lib/configFactory.ts 100.00% <100.00%> (ø)
... and 15 more

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f2a0a...c3e2ea6. Read the comment docs.

@thorkellmani thorkellmani marked this pull request as ready for review May 2, 2024 13:58
@thorkellmani thorkellmani requested a review from a team as a code owner May 2, 2024 13:58
Copy link
Member

@busla busla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra LGTM

Copy link
Member

@RunarVestmann RunarVestmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve the 1 file that stefna owns but have a comment

libs/cms/src/lib/cms.contentful.service.ts Outdated Show resolved Hide resolved
Copy link
Member

@obmagnusson obmagnusson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowned file LGTM

@thorkellmani thorkellmani added automerge Merge this PR as soon as all checks pass and removed deploy-feature Deploys features to dev labels May 6, 2024
@thorkellmani thorkellmani added automerge Merge this PR as soon as all checks pass and removed automerge Merge this PR as soon as all checks pass labels May 7, 2024
Copy link
Contributor

kodiakhq bot commented May 7, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge Merge this PR as soon as all checks pass label May 7, 2024
@thorkellmani thorkellmani added the automerge Merge this PR as soon as all checks pass label May 7, 2024
@kodiakhq kodiakhq bot merged commit f7738d0 into main May 7, 2024
252 of 253 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-university-clients branch May 7, 2024 14:57
Ballioli pushed a commit that referenced this pull request May 17, 2024
* feat: init

* feat: lhbi

* fix: remove lbhi

* feat: init

* feat: init

* feat: init

* feat: generate

* feat: generate

* feat: generate

* chore: prettier

* feat: generate

* feat: add service nad generate

* feat: move into

* feat: gen

* feat: rem and gen again

* fix: n again

* feat: gen

* feat: move

* feat: rem and gen

* feat: gen

* feat: gen

* feat: one client

* fix: compatibiliy

* chore: remove old

* chore: charts update dirty files

* feat: gen api domain

* feat: add to domain

* chore/update-codeowners

* feat: gql finagling

* fix: imports

* chore: codeowners

* fix: codeowenrs

* chore:lint

* fix: build

* fix: scope

* feat: change graphql model

* fix: enum

* fix: loading

* chore: clean up

* feat: detail works

* fix: organization mapping

* chore: nx format:write update dirty files

* chore: add xroad def to infra

* chore: charts update dirty files

* chore: fix env name

* feat: clean up intro headers

* fix: module imports

* fix: logos

* feat: logo fix

* feat: better mapping

* fix: type error

* chore: nx format:write update dirty files

* feat: add warning screen if no transcripts

* fix: remove logging import

* fix: remove logging

* fix: import

* fix: no match

* fix: update image url

* chore: clean up

---------

Co-authored-by: Þorkell Máni Þorkelsson <[email protected]>
Co-authored-by: andes-it <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants