fix(parental-leave): Change type when applying for Dvalarstyrk #14392

birkirkristmunds · 2024-04-08T10:29:27Z

https://dit-iceland.atlassian.net/browse/UUFV-435

Why

Fix the type sent to VMST when applying for Dvalarstyrkur

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

Refactor
- Streamlined the application process in the Parental Leave service, enhancing the flow and simplifying state management.
New Features
- Enhanced state-specific logic handling in the Parental Leave module to better accommodate changes related to employer and period adjustments.
Improvements
- Updated the Parental Leave Template to improve application validation and submission processes.

coderabbitai · 2024-04-08T10:29:33Z

Walkthrough

The updates aim to refine the logic for managing application states and actions within the parental leave system. Changes involve removing unnecessary parameters, enhancing state-specific logic, and introducing new utility functions to determine action names based on user inputs and application states. These modifications streamline code, improving the clarity and efficiency of state transitions and action determinations in the parental leave application process.

Changes

File Path	Change Summary
.../template-api-modules/.../parental-leave.service.ts	Removed `previousState` parameter in `getApplicationAnswers`, simplified `actionNameFromParams`.
.../template-api-modules/.../parental-leave.utils.ts	Added `States` import, refactored `checkActionName`, added `getType` function.
.../templates/parental-leave/.../ParentalLeaveTemplate.ts	Added `'setActionName'` entry, removed `params` value assignment.
.../templates/parental-leave/.../parentalLeaveUtils.ts	Updated summary, added `getActionName` to determine action type based on state and user choices.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Status

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between e82cb9b and 9f4dcd3.

Files selected for processing (1)

libs/application/templates/parental-leave/src/lib/ParentalLeaveTemplate.ts (1 hunks)

Additional Context Used

Path-based Instructions (1)

libs/application/templates/parental-leave/src/lib/ParentalLeaveTemplate.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

Reusability of components and hooks across different NextJS apps.

TypeScript usage for defining props and exporting types.

Effective tree-shaking and bundling practices."

Additional comments not posted (2)

libs/application/templates/parental-leave/src/lib/ParentalLeaveTemplate.ts (2)

866-866: The change from FileType.DOCUMENTPERIOD to FileType.DOCUMENT aligns with the PR objectives to meet VMST validation requirements.

863-869: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-866]

Ensure TypeScript types are consistently used throughout the file for props and exported types, enhancing maintainability and developer experience.

codecov · 2024-04-08T10:38:53Z

Codecov Report

Attention: Patch coverage is 83.60656% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 37.03%. Comparing base (cfc06df) to head (704bfc1).
Report is 1 commits behind head on main.

❗ Current head 704bfc1 differs from pull request most recent head a0f94ff. Consider uploading reports for the commit a0f94ff to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14392      +/-   ##
==========================================
- Coverage   37.16%   37.03%   -0.13%     
==========================================
  Files        6237     6224      -13     
  Lines      126387   125939     -448     
  Branches    36159    36007     -152     
==========================================
- Hits        46977    46647     -330     
+ Misses      79410    79292     -118

Flag	Coverage Δ
api	`3.47% <ø> (ø)`
application-system-api	`42.13% <39.34%> (+0.02%)`	⬆️
application-template-api-modules	`24.64% <54.09%> (+0.06%)`	⬆️
application-templates-parental-leave	`25.45% <75.00%> (-2.96%)`	⬇️
application-ui-shell	`21.72% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...rental-leave/src/lib/parentalLeaveTemplateUtils.ts	`59.09% <100.00%> (+2.46%)`	⬆️
...templates/parental-leave/parental-leave.service.ts	`49.06% <93.33%> (+0.10%)`	⬆️
...s/templates/parental-leave/parental-leave.utils.ts	`84.21% <80.00%> (+4.70%)`	⬆️
...es/parental-leave/src/lib/ParentalLeaveTemplate.ts	`62.10% <80.00%> (-1.54%)`	⬇️
...lates/parental-leave/src/lib/parentalLeaveUtils.ts	`44.44% <80.00%> (-9.88%)`	⬇️

... and 88 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb7eaf...a0f94ff. Read the comment docs.

datadog-island-is · 2024-04-08T10:47:20Z

Datadog Report

All test runs 8a2b083 🔗

✅ 6 Total Test Services: 0 Failed, 6 Passed
🔻 Test Sessions change in coverage: 1 decreased (-3.48%), 2 increased, 6 no change

Test Services

Service Name	Passed	Skipped	Wall Time	Code Coverage Change	Test Service View
`api`	4	0	20.16ms	1 no change	Link
`application-system-api`	111	2	1m 19.73s	1 increased (+0.01%)	Link
`application-template-api-modules`	107	0	1m 9.91s	1 increased (+0.04%)	Link
`application-templates-parental-leave`	93	62	14.57s	1 decreased (-3.48%)	Link
`application-ui-shell`	74	0	41.89s	1 no change	Link
`web`	84	0	3.71s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (1)

application-templates-parental-leave - jest 29.78% (-3.48%) - Details

coderabbitai

Actionable comments posted: 0

Review Status

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 9f4dcd3 and 97507a0.

Files selected for processing (1)

libs/application/templates/parental-leave/src/lib/ParentalLeaveTemplate.ts (2 hunks)

Files skipped from review as they are similar to previous changes (1)

libs/application/templates/parental-leave/src/lib/ParentalLeaveTemplate.ts

kodiakhq · 2024-04-10T13:20:11Z

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

…lication

…en callin validateApplication

...tion/template-api-modules/src/lib/modules/templates/parental-leave/parental-leave.service.ts

...cation/template-api-modules/src/lib/modules/templates/parental-leave/parental-leave.utils.ts

…lication

coderabbitai

Actionable comments posted: 1

libs/application/templates/parental-leave/src/lib/parentalLeaveUtils.ts

…lication

karenbjorg

lgtm

…lication

UUFV-435 Change type when applying for Dvalarstyrk

9f4dcd3

birkirkristmunds requested a review from a team as a code owner April 8, 2024 10:29

coderabbitai bot approved these changes Apr 8, 2024

View reviewed changes

UUFV-435 Change type to Document in sendApplication

97507a0

coderabbitai bot reviewed Apr 8, 2024

View reviewed changes

birkirkristmunds added the automerge Merge this PR as soon as all checks pass label Apr 8, 2024

UUFV-435 Refactor code. Not use params

052c971

kodiakhq bot removed the automerge Merge this PR as soon as all checks pass label Apr 10, 2024

birkirkristmunds and others added 3 commits April 10, 2024 14:05

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

22184d6

…lication

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

12e1d94

…lication

UUFV-435 Fix the employer or periods actionName is one step behind wh…

17046df

…en callin validateApplication

karenbjorg reviewed Apr 12, 2024

View reviewed changes

birkirkristmunds and others added 6 commits April 12, 2024 12:41

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

9273599

…lication

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

e91bcd2

…lication

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

ea0547f

…lication

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

e861f18

…lication

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

8497c54

…lication

UUFV-435 Fix send actionName is one behind.

915d6d3

coderabbitai bot requested changes Apr 22, 2024

View reviewed changes

libs/application/templates/parental-leave/src/lib/parentalLeaveUtils.ts Outdated Show resolved Hide resolved

birkirkristmunds and others added 2 commits April 22, 2024 13:37

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

bcf56fe

…lication

UUFV-435 Fix after coderabbit suggestions

c03f823

coderabbitai bot approved these changes Apr 22, 2024

View reviewed changes

birkirkristmunds requested a review from karenbjorg April 22, 2024 14:07

birkirkristmunds added 3 commits April 24, 2024 15:18

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

32c3d36

…lication

UUFV-435 Fix after merge

8b21771

UUFV-435 Add back set changeEmployer & changePeriods

0bd66a8

birkirkristmunds added 2 commits April 26, 2024 14:04

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

856cd23

…lication

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

704bfc1

…lication

birkirkristmunds added the automerge Merge this PR as soon as all checks pass label Apr 29, 2024

karenbjorg approved these changes Apr 30, 2024

View reviewed changes

Merge branch 'main' into fix/parental-leave-set-type-when-editing-app…

a0f94ff

…lication

kodiakhq bot merged commit 3121924 into main Apr 30, 2024
34 checks passed

kodiakhq bot deleted the fix/parental-leave-set-type-when-editing-application branch April 30, 2024 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(parental-leave): Change type when applying for Dvalarstyrk #14392

fix(parental-leave): Change type when applying for Dvalarstyrk #14392

birkirkristmunds commented Apr 8, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 8, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

codecov bot commented Apr 8, 2024 •

edited

Loading

datadog-island-is bot commented Apr 8, 2024 •

edited

Loading

coderabbitai bot left a comment

kodiakhq bot commented Apr 10, 2024

coderabbitai bot left a comment

karenbjorg left a comment

fix(parental-leave): Change type when applying for Dvalarstyrk #14392

fix(parental-leave): Change type when applying for Dvalarstyrk #14392

Conversation

birkirkristmunds commented Apr 8, 2024 • edited by coderabbitai bot Loading

Why

Checklist:

Summary by CodeRabbit

coderabbitai bot commented Apr 8, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 8, 2024 • edited Loading

Codecov Report

datadog-island-is bot commented Apr 8, 2024 • edited Loading

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (1)

coderabbitai bot left a comment

Choose a reason for hiding this comment

kodiakhq bot commented Apr 10, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

karenbjorg left a comment

Choose a reason for hiding this comment

birkirkristmunds commented Apr 8, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 8, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Apr 8, 2024 •

edited

Loading

datadog-island-is bot commented Apr 8, 2024 •

edited

Loading