fix(general-petition): Fix form validation

[joningi98]

What

General petition form was not validating if the dates where the same nor the email or phone number of the applicant

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1207148243073948
  • https://app.asana.com/0/0/1207148243073942

Summary by CodeRabbit

• Bug Fixes

  • Improved validation logic for petition dates to ensure the start date is strictly before the end date.
  • Enhanced phone and email field validations for better accuracy and user data integrity.

• Documentation

  • Updated user-facing error messages for better clarity during form validation errors.

[coderabbitai]

Walkthrough

The recent refinements focus on enhancing the validation rules within the GeneralPetitionSchema. Changes include implementing strict inequality for date comparisons and strengthening validation for phone and email fields in terms of format and length. Additionally, adjustments have been made to user feedback messages in messages.ts to align with these modifications.

Changes

File Path	Change Summary
.../general-petition/src/lib/dataSchema.ts	Updated dateFrom and dateTil to use strict inequality. Added length validation for phone and email.
.../general-petition/src/lib/messages.ts	Updated default messages for validationTilBeforeFrom, validationPhone, and validationEmail.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[datadog-island-is]

Datadog Report

All test runs 6033289 🔗

✅ 5 Total Test Services: 0 Failed, 5 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.04%), 7 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	24.77ms	1 no change	Link
application-system-api	0	0	0	111	2	1m 24.18s	1 no change	Link
application-templates-general-petition	0	0	0	5	0	35.14ms	1 decreased (-0.04%)	Link
application-ui-shell	0	0	0	74	0	18.08s	1 no change	Link
web	0	0	0	84	0	3.67s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (1)

• application-templates-general-petition - jest 22% (-0.04%) - Details

[coderabbitai]

Actionable comments posted: 2

Out of diff range and nitpick comments (1)

libs/application/templates/general-petition/src/lib/dataSchema.ts (1)

53-53: The change in date validation logic looks good. Consider adding a comment explaining why dateFrom must be strictly less than dateTil.

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 37.16%. Comparing base (5cd0ad6) to head (b85f581).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14589      +/-   ##
==========================================
- Coverage   37.16%   37.16%   -0.01%     
==========================================
  Files        6237     6237              
  Lines      126379   126379              
  Branches    36156    36156              
==========================================
- Hits        46970    46969       -1     
- Misses      79409    79410       +1     

Flag	Coverage Δ
api	3.47% <ø> (ø)
application-system-api	42.11% <ø> (ø)
application-templates-general-petition	19.00% <16.66%> (-0.03%)	⬇️
application-ui-shell	21.72% <ø> (ø)
web	1.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ion/templates/general-petition/src/lib/messages.ts	100.00% <ø> (ø)
...n/templates/general-petition/src/lib/dataSchema.ts	31.25% <16.66%> (-2.09%)	⬇️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd0ad6...b85f581. Read the comment docs.