Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): paginated data in petition view #14631

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Conversation

albinagu
Copy link
Member

@albinagu albinagu commented Apr 29, 2024

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Improved date formatting for consistency across the PetitionView screen.
    • Refactored pagination to enhance navigation through petitions using cursor-based logic.
  • Bug Fixes

    • Adjusted visual layout of skeleton loaders to better match content sizes during loading states.
  • Refactor

    • Streamlined data fetching for endorsements with updated query structures.
  • Documentation

    • Added utility functions for consistent date formatting and base URL retrieval.

@albinagu albinagu requested a review from a team as a code owner April 29, 2024 12:49
Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

The changes primarily focus on refining the PetitionView screen. Modifications include adjusting the layout of loading skeletons, revamping pagination logic with cursor-based navigation, and enhancing date formatting. Unnecessary interfaces were removed, and new utility functions were introduced to streamline operations, aiming to improve user experience and code maintainability.

Changes

File Path Change Summary
.../PetitionSkeleton.tsx Adjusted heights of SkeletonLoader components for visual layout.
.../PetitionView.tsx Imported SkeletonLoader, refactored pagination logic, updated endorsements handling, and improved date formatting.
.../queries.ts Removed old interfaces, added new imports, updated queries with pageInfo fields.
.../utils.ts Introduced utility functions for date formatting, base URL retrieval, and setting page size.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

apps/web/screens/PetitionView/utils.ts Show resolved Hide resolved
@datadog-island-is
Copy link

datadog-island-is bot commented Apr 29, 2024

Datadog Report

All test runs 5c83afa 🔗

12 Total Test Services: 1 Failed, 11 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.02%), 1 increased (+0.04%), 21 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Code Coverage Change Test Service View
services-auth-personal-representative 1 0 0 58 0 43.67s 1 no change Link
api 0 0 0 4 0 32.15ms 1 no change Link
api-domains-auth-admin 0 0 0 18 0 565.2ms 1 no change Link
application-system-api 0 0 0 111 2 1m 22.42s 1 no change Link
application-template-api-modules 0 0 0 107 0 47.33s 1 no change Link
auth-api-lib 0 0 0 13 0 7.93s 1 increased (+0.04%) Link
services-auth-admin-api 0 0 0 98 0 1m 56.69s 1 no change Link
services-auth-delegation-api 0 0 0 254 0 2m 6.96s 1 no change Link
services-auth-ids-api 0 0 0 193 0 32s 1 no change Link
services-user-notification 0 0 0 41 0 40.02s 1 decreased (-0.02%) Link

❌ Failed Tests (1)

  • AccessLogsController Get access-logs Get /v1/access-logs should return logs connected to specific represented person - apps/services/auth/personal-representative/src/app/modules/accessLogs/e2e/accessLogs.spec.ts - Details

    Expand for error
     expect(received).toMatchObject(expected)
     
     Matcher error: received value must be a non-null object
     
     Received has value: undefined
    

🔻 Code Coverage Decreases vs Default Branch (1)

  • services-user-notification - jest 48.57% (-0.02%) - Details

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 37.14%. Comparing base (a62ffa8) to head (fa514fa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14631      +/-   ##
==========================================
- Coverage   37.16%   37.14%   -0.03%     
==========================================
  Files        6237     6236       -1     
  Lines      126372   126366       -6     
  Branches    36149    36148       -1     
==========================================
- Hits        46969    46936      -33     
- Misses      79403    79430      +27     
Flag Coverage Δ
web 1.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apps/web/screens/PetitionView/PetitionSkeleton.tsx 0.00% <ø> (ø)
apps/web/screens/PetitionView/queries.ts 0.00% <0.00%> (ø)
apps/web/screens/PetitionView/utils.ts 0.00% <0.00%> (ø)
apps/web/screens/PetitionView/PetitionView.tsx 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62ffa8...fa514fa. Read the comment docs.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

apps/web/screens/PetitionView/PetitionView.tsx Outdated Show resolved Hide resolved
@albinagu albinagu added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Apr 29, 2024
@kodiakhq kodiakhq bot merged commit 5cd0ad6 into main Apr 30, 2024
33 checks passed
@kodiakhq kodiakhq bot deleted the web_petitions_paginated_data branch April 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants