Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Stop server side rendering some dynamically imported footers #14634

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Apr 29, 2024

Stop server side rendering some dynamically imported footers

What

This PR will:

  1. Stop server side rendering dynamically imported footers that are having this issue
  2. Make sure that NTÍ footer starts off in desktop size to prevent layout jump
  3. Change Fiskistofa footer from using Box components to div's (since I've seen that the issue relates to the Box component as was in this case: fix(web): Change Box components to divs for Organization headers #9913)

Screenshots / Gifs

Screen.Recording.2024-04-29.at.14.21.49.mov

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@RunarVestmann RunarVestmann added the automerge Merge this PR as soon as all checks pass label Apr 29, 2024
@RunarVestmann RunarVestmann requested a review from a team as a code owner April 29, 2024 14:22
Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

The recent updates primarily involve modifications to server-side rendering settings across several theme components, switching from enabled (true) to disabled (false). Additionally, there are changes in the FiskistofaTheme related to CSS imports and element replacements from Box to div. The IcelandicNaturalDisasterInsuranceTheme introduces responsive behavior through the use of hooks.

Changes

File Path Change Summary
.../FiskistofaTheme/FiskistofaFooter.css.ts Added theme import and used theme.spacing[2] for marginLeft.
.../FiskistofaTheme/FiskistofaFooter.tsx Replaced Box with div elements and updated related class names and image/icon rendering.
.../HeilbrigdisstofnunAusturlandsTheme/index.ts, .../HeilbrigdisstofnunNordurlandsTheme/index.ts, .../HeilbrigdisstofnunSudurlandsTheme/index.ts, .../HveTheme/index.ts, .../LandlaeknirTheme/index.ts Modified SSR behavior from true to false for respective footer components.
.../IcelandicNaturalDisasterInsuranceTheme/IcelandicNaturalDisasterInsuranceFooter.tsx Added useEffect and useState to manage responsive shouldWrap state based on window width.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@datadog-island-is
Copy link

datadog-island-is bot commented Apr 29, 2024

Datadog Report

Branch report: fix/web-footer-dynamic-import-messes-with-styles
Commit report: 32dab99
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 3.61s Wall Time
➡️ Test Sessions change in coverage: 1 no change

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 37.16%. Comparing base (cfc06df) to head (3eafc2e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14634      +/-   ##
==========================================
- Coverage   37.16%   37.16%   -0.01%     
==========================================
  Files        6237     6237              
  Lines      126387   126389       +2     
  Branches    36159    36159              
==========================================
  Hits        46977    46977              
- Misses      79410    79412       +2     
Flag Coverage Δ
web 1.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rapper/Themes/FiskistofaTheme/FiskistofaFooter.tsx 0.00% <ø> (ø)
...Themes/HeilbrigdisstofnunAusturlandsTheme/index.ts 0.00% <ø> (ø)
...Themes/HeilbrigdisstofnunNordurlandsTheme/index.ts 0.00% <ø> (ø)
.../Themes/HeilbrigdisstofnunSudurlandsTheme/index.ts 0.00% <ø> (ø)
...anization/Wrapper/Themes/LandlaeknirTheme/index.ts 0.00% <ø> (ø)
...ents/Organization/Wrapper/Themes/HveTheme/index.ts 0.00% <0.00%> (ø)
...eTheme/IcelandicNaturalDisasterInsuranceFooter.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc06df...3eafc2e. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 9bb7eaf into main Apr 30, 2024
30 checks passed
@kodiakhq kodiakhq bot deleted the fix/web-footer-dynamic-import-messes-with-styles branch April 30, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants