feat(j-s): Service requirement #14644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe recent updates revolve around implementing a new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14644 +/- ##
=======================================
Coverage 37.00% 37.00%
=======================================
Files 6263 6263
Lines 127104 127095 -9
Branches 36370 36365 -5
=======================================
Hits 47033 47033
+ Misses 80071 80062 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 41 Total Test Services: 0 Failed, 40 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (2) |
gudjong
approved these changes
May 6, 2024
apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts
Outdated
Show resolved
Hide resolved
….is into j-s/service-requirement
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts (1 hunks)
- apps/judicial-system/web/src/components/SectionHeading/SectionHeading.tsx (2 hunks)
- apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (3)
- apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts
- apps/judicial-system/web/src/components/SectionHeading/SectionHeading.tsx
- apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts
brynjarorng
added a commit
that referenced
this pull request
May 7, 2024
* fix(university-gateway): adding back specilization (#14709) * feat(system-e2e): Move system-e2e to NX, v3 (#14505) * Revert "Revert "feat(system-e2e): Move system-e2e to NX (#14283)" (#14500)" This reverts commit 2128dba. * squash-cherry-pick #14094 * squash-cherry-pick #14498 * Don't use _podman.sh * Revert tsconfig in system-e2e back to main * Quoting and default in _docker.sh * Use yarn, not npx when running playwright * ci: levy debug * Reset services to main * entrypoint.sh cleanup * Re-add custom addons * Revert Dockerfile to main * Copy only playwright parts from #14094 * Add bash to build image * Pin patch versions * reviewfix * Removed unused targets * Use common logger (from infra) * Revert scripts/ back (mostly) to main * Explain bash install in dockerfile * Handle missing playwright to prevent obscure errors * Don't force --output parameter usage * use _podman.sh for local * Also build *.d.ts * Set entrypoint to call notify.* to allow ts and js * Remove custom expect matchers * Only use a single browser, not all * Fix entrypoint playwright.config reference * Remove toBeApplication usage * Remove toHaveCountGreaterThan usage * Remove unused typing file * Some linting * lintfix * Remove unused code * Only use logger * Fixed log usage * Use suggested esbuild executor * Revert "Use suggested esbuild executor" This reverts commit 0f8dfe8. --------- Co-authored-by: Jón Levy <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(service-portal): Documents logging and ui fixes. (#14707) * Update doc service v2 * log doc id * Update documentsClientV2.service.ts * Update documentsClientV2.service.ts --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(j-s): Robot Appeal Ruling Date (#14706) * Fixes date columns * Removes logging --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(j-s): Use Table component for prison cases (#14673) * Use Table component for prison cases * Remove unused import * Remove unused code * Add appeal state tags * Memoize renderTabl * Fix types --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(j-s): Service requirement (#14644) * Add field to defendant table * Add radiobuttons to indictmentoverview page * UI tweeks * Sending to public prosecutor is now an action * District court users now have a dedicated indictment overview page * Remove unused export * Fix types --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Revert "feat(system-e2e): Move system-e2e to NX, v3 (#14505)" (#14713) This reverts commit c29664f. * fix(service-portal): Add couple of housing benefit ui fixes (#14711) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --------- Co-authored-by: berglindoma13 <[email protected]> Co-authored-by: Kristofer <[email protected]> Co-authored-by: Jón Levy <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Þórður H <[email protected]> Co-authored-by: Guðjón Guðjónsson <[email protected]> Co-authored-by: Ívar Oddsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service requirement
Asana
What
Implement a way for district judges and registrars to determine the service requirements, i.e. whether or not a ruling needs to be served to convicts in indictment cases, for each convicted person.
Why
This is the first step in creating a tool for Ríkissaksóknari. They need this info to be able to determine whether or not to appeal cases to the court of appeals or not.
Screenshots / Gifs
Screen.Recording.2024-04-30.at.14.03.44.mov
Checklist:
Summary by CodeRabbit
New Features
BlueBox,SectionHeading, andTextto improve visual presentation and user interaction.Bug Fixes
Refactor
IndictmentOverviewcomponent toOverview, ensuring better organization and clarity in the codebase.