chore: Don't log 4xx as error

libs/clients/administration-of-occupational-safety-and-health/src/lib/api.provider.ts

@@ -10,7 +10,6 @@ export const ApiConfig = {
       fetchApi: createEnhancedFetch({
         name: 'clients-administration-of-occupational-safety-and-health',
         logErrorResponseBody: true,
-        treat400ResponsesAsErrors: true,
         organizationSlug: 'vinnueftirlitid',
       }),
       basePath: 'https://ws.ver.is/namskeid',

libs/clients/aircraft-registry/src/lib/apiConfig.ts

@@ -18,7 +18,6 @@ export const ApiConfig = {
       fetchApi: createEnhancedFetch({
         name: 'clients-aircraft-registry',
         organizationSlug: 'samgongustofa',
-        treat400ResponsesAsErrors: true,
       }),
       basePath: `${xroadConfig.xRoadBasePath}/r1/${config.xRoadServicePath}`,
       headers: {

libs/clients/housing-benefit-calculator/src/lib/housing-benefit-calculator.provider.ts

@@ -18,7 +18,6 @@ export const ApiConfig = {
       fetchApi: createEnhancedFetch({
         name: 'clients-housing-benefit-calculator',
         logErrorResponseBody: true,
-        treat400ResponsesAsErrors: true,
       }),
       basePath: `${xroadConfig.xRoadBasePath}/r1/${config.xRoadServicePath}`,
       headers: {

libs/clients/icelandic-government-institution-vacancies/src/lib/apiConfig.ts

@@ -26,7 +26,6 @@ export const ApiConfig = {
         name: 'clients-icelandic-government-institution-vacancies',
         organizationSlug: 'fjarsysla-rikisins',
         logErrorResponseBody: true,
-        treat400ResponsesAsErrors: true,
         timeout: 20000,
       }),
       basePath: `${xroadConfig.xRoadBasePath}/r1/${config.xRoadServicePath}`,

libs/clients/icelandic-health-insurance/health-insurance/src/lib/clients-health-insurance-v2.module.ts

@@ -13,7 +13,6 @@ export class HealthInsuranceV2Client {
       fetchApi: createEnhancedFetch({
         name: 'clients-health-insurance',
         organizationSlug: 'sjukratryggingar',
-        treat400ResponsesAsErrors: true,
         logErrorResponseBody: true,
         timeout: 20000, // needed because the external service is taking a while to respond to submitting the document
       }),

libs/clients/middlewares/README.md

@@ -26,7 +26,6 @@ A new library providing an createEnhancedFetch function.
 - `name: string` - Name of fetch function. Used in logs and opossum stats.
 - `enableCircuitBreaker?: boolean` - Should use circuit breaker for requests. Defaults to `true`.
 - `timeout?: number | false` - Timeout for requests. Logged and thrown as errors. May cause circuit breaker to open. Defaults to `10000`ms. Can be disabled by passing false.
-- `treat400ResponsesAsErrors?: boolean` - If `true`, then too many 400 responses may cause the circuit to open. Either way these responses will be logged and thrown. Defaults to `false`.
 - `logErrorResponseBody?: boolean` - If `true`, then non-200 response bodies will be consumed and included in the error object and logged as `body`.
 - `keepAlive?: boolean | number` - Configures keepAlive for requests. If `false`, never reuse connections. If `true`, reuse connection with a maximum idle timeout of 10 seconds. By passing a number you can override the idle connection timeout. Defaults to `true`.
 - `clientCertificate?: ClientCertificateOptions` - Configures client certificate for requests.

libs/clients/middlewares/src/lib/createEnhancedFetch.spec.ts

@@ -209,7 +209,7 @@ describe('EnhancedFetch', () => {
 
   it('can be configured to open circuit for 400 errors', async () => {
     // Arrange
-    env = setupTestEnv({ treat400ResponsesAsErrors: true })
+    env = setupTestEnv({})
     env.fetch.mockResolvedValue(fakeResponse('Error', { status: 400 }))
     await env.enhancedFetch(testUrl).catch(() => null)
 

libs/clients/middlewares/src/lib/createEnhancedFetch.ts

@@ -63,12 +63,6 @@ export interface EnhancedFetchOptions {
    */
   forwardAuthUserAgent?: boolean
 
-  /**
-   * By default, 400 responses are considered warnings and will not open the circuit.
-   * Either way they will be logged and thrown.
-   */
-  treat400ResponsesAsErrors?: boolean
-
   /**
    * If true (default), Enhanced Fetch will log error response bodies.
    * Should be set to false if error objects may have sensitive information or PII.
@@ -159,7 +153,6 @@ export const createEnhancedFetch = (
     metricsClient = new DogStatsD({ prefix: `${options.name}.` }),
     organizationSlug,
   } = options
-  const treat400ResponsesAsErrors = options.treat400ResponsesAsErrors === true
   const freeSocketTimeout =
     typeof keepAlive === 'number'
       ? keepAlive
@@ -207,7 +200,6 @@ export const createEnhancedFetch = (
     builder.wrap(withCircuitBreaker, {
       name,
       logger,
-      treat400ResponsesAsErrors,
       opossum,
     })
   }
@@ -233,7 +225,6 @@ export const createEnhancedFetch = (
   builder.wrap(withErrorLog, {
     name,
     logger,
-    treat400ResponsesAsErrors,
   })
 
   return builder.getFetch()

libs/clients/middlewares/src/lib/withCircuitBreaker.ts

@@ -5,28 +5,24 @@ import { MiddlewareAPI } from './nodeFetch'
 import { FetchError } from './FetchError'
 
 export interface CircuitBreakerOptions {
-  treat400ResponsesAsErrors: boolean
   opossum: CircuitBreaker.Options
   fetch: MiddlewareAPI
   name: string
   logger: Logger
 }
 
 export function withCircuitBreaker({
-  treat400ResponsesAsErrors,
   opossum,
   fetch,
   name,
   logger,
 }: CircuitBreakerOptions): MiddlewareAPI {
-  const errorFilter = treat400ResponsesAsErrors
-    ? opossum?.errorFilter
-    : (error: FetchError) => {
-        if (error.name === 'FetchError' && error.status < 500) {
-          return true
-        }
-        return opossum?.errorFilter?.(error) ?? false
-      }
+  const errorFilter = (error: FetchError) => {
+    if (error.name === 'FetchError' && error.status < 500) {
+      return true
+    }
+    return opossum?.errorFilter?.(error) ?? false
+  }
 
   const breaker = new CircuitBreaker(fetch, {
     name,

libs/clients/middlewares/src/lib/withErrorLog.ts

@@ -6,23 +6,17 @@ import { FetchError } from './FetchError'
 interface ErrorLogOptions extends FetchMiddlewareOptions {
   name: string
   logger: Logger
-  treat400ResponsesAsErrors: boolean
 }
 
 export function withErrorLog({
   name,
   fetch,
-  treat400ResponsesAsErrors,
   logger,
 }: ErrorLogOptions): MiddlewareAPI {
   return (request) => {
     return fetch(request).catch((error: Error) => {
       const logLevel =
-        error instanceof FetchError &&
-        error.status < 500 &&
-        !treat400ResponsesAsErrors
-          ? 'warn'
-          : 'error'
+        error instanceof FetchError && error.status < 500 ? 'warn' : 'error'
       const cacheStatus =
         (error instanceof FetchError &&
           error.response.headers.get('cache-status')) ??

libs/clients/ship-registry/src/lib/ship-registry.provider.ts

@@ -18,7 +18,6 @@ export const ApiConfig = {
       fetchApi: createEnhancedFetch({
         name: 'clients-ship-registry',
         logErrorResponseBody: true,
-        treat400ResponsesAsErrors: true,
       }),
       basePath: `${xroadConfig.xRoadBasePath}/r1/${config.xRoadServicePath}`,
       headers: {