Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Custom Page - OpenGraph fields and rich text field added #14651

Merged
merged 3 commits into from
May 2, 2024

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Apr 30, 2024

Custom Page - OpenGraph fields and rich text field added

What

  • Custom pages might have a custom og:image, og:title or og:description so those fields were added to the CMS content type
  • Also a content field was added to the Custom Page content type which will allow for rich text

Why

  • This is an expansion for the Custom Page content type to provide fields and functionality shared between custom pages

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced social sharing capabilities by integrating HeadWithSocialSharing component for custom pages, allowing dynamic metadata such as title, description, and images.
    • Expanded GraphQL queries to include additional content fields and social metadata for a richer page experience.
  • Enhancements

    • Updated the ICustomPageFields interface and CustomPage model to support new content types and social sharing attributes.

@RunarVestmann RunarVestmann added the automerge Merge this PR as soon as all checks pass label Apr 30, 2024
Copy link
Contributor

coderabbitai bot commented Apr 30, 2024

Walkthrough

The recent updates primarily enhance the functionality related to social media sharing for custom pages. This includes the integration of the HeadWithSocialSharing component and extending GraphQL queries to fetch additional metadata like titles, descriptions, and images. Changes also involve updating interfaces and models to accommodate new content fields and social media attributes, ensuring a more dynamic and SEO-friendly presentation of custom pages.

Changes

Files Change Summary
.../CustomPageWrapper.tsx, .../CustomPage.ts Enhanced social sharing capabilities by adding components and extending GraphQL queries with social media related fields.
.../contentfulTypes.d.ts, .../customPage.model.ts Updated data models and interfaces to include new fields for content and social media metadata, improving content management and representation.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RunarVestmann RunarVestmann marked this pull request as ready for review April 30, 2024 16:47
@RunarVestmann RunarVestmann requested review from a team as code owners April 30, 2024 16:47
@datadog-island-is
Copy link

datadog-island-is bot commented Apr 30, 2024

Datadog Report

All test runs b09f7dd 🔗

13 Total Test Services: 0 Failed, 12 Passed
⬆️ Test Sessions change in coverage: 5 increased, 24 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Code Coverage Change Test Service View
api 0 0 0 4 0 34.89ms 1 no change Link
api-domains-communications 0 0 0 5 0 138.38ms 1 increased (+0.02%) Link
api-domains-license-service 0 0 0 0 0 0s 1 no change Link
application-system-api 0 0 0 111 2 1m 16.21s 1 increased (+0.01%) Link
application-template-api-modules 0 0 0 107 0 46.91s 1 increased (+0.02%) Link
cms-translations 0 0 0 3 0 22.2ms 1 increased (+0.02%) Link
judicial-system-api 0 0 0 52 0 310.35ms 1 no change Link
judicial-system-backend 0 0 0 13136 0 15m 35.22s 1 no change Link
judicial-system-formatters 0 0 0 36 0 402.72ms 1 no change Link
judicial-system-web 0 0 0 311 0 48.6s 1 no change Link

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 37.09%. Comparing base (78660fe) to head (4379e01).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #14651   +/-   ##
=======================================
  Coverage   37.09%   37.09%           
=======================================
  Files        6240     6238    -2     
  Lines      126388   126377   -11     
  Branches    36156    36144   -12     
=======================================
  Hits        46882    46882           
+ Misses      79506    79495   -11     
Flag Coverage Δ
api 3.47% <ø> (ø)
api-domains-communications 40.32% <46.15%> (+<0.01%) ⬆️
application-system-api 42.14% <46.15%> (+<0.01%) ⬆️
application-template-api-modules 24.64% <ø> (ø)
cms 0.45% <0.00%> (-0.01%) ⬇️
cms-translations 39.40% <46.15%> (+0.01%) ⬆️
judicial-system-api 16.97% <ø> (ø)
services-user-notification 47.40% <46.15%> (+0.03%) ⬆️
web 1.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apps/web/screens/queries/CustomPage.ts 0.00% <ø> (ø)
apps/web/screens/CustomPage/CustomPageWrapper.tsx 0.00% <0.00%> (ø)
libs/cms/src/lib/models/customPage.model.ts 51.51% <46.15%> (-3.49%) ⬇️

... and 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78660fe...4379e01. Read the comment docs.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

apps/web/screens/queries/CustomPage.ts Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit eb2759d into main May 2, 2024
57 checks passed
@kodiakhq kodiakhq bot deleted the feature/web-custom-page-seo-and-content-field branch May 2, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants