Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(j-s): Postponed Indefinitely Explanation #14655

Merged
merged 3 commits into from
May 2, 2024

Conversation

gudjong
Copy link
Member

@gudjong gudjong commented May 1, 2024

Postponed Indefinitely Explanation

Frestun - Info card fyrir frestun um óákveðinn tíma

What

  • Displays an info card with the postponed indefinitely explanation instead of the court date when a case is postponed indefinitely.

Why

  • This is according to design.

Screenshots / Gifs

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Introduced new roles such as spokesperson and defender in the InfoCard components.
    • Added localization for various InfoCard components to enhance user experience in different languages.
    • Launched new components for handling scheduled and postponed indictment cases.
  • Enhancements

    • Updated existing InfoCard components to use localized strings for better consistency and maintainability.
  • Bug Fixes

    • Removed the postponedIndefinitelyExplanation prop from various components to streamline the interface and improve clarity.
  • Documentation

    • Added documentation strings for new and existing InfoCard components to aid in development and usage understanding.

@gudjong gudjong requested a review from a team as a code owner May 1, 2024 12:00
Copy link
Contributor

coderabbitai bot commented May 1, 2024

Walkthrough

The updates across various components in the judicial system web application primarily focus on enhancing internationalization and refactoring code for clarity. Changes include renaming variables, removing outdated props, and introducing new string files for better localization. These modifications aim to streamline the codebase and improve the adaptability of the user interface across different languages.

Changes

File Path Change Summary
.../InfoCard/InfoCard.strings.ts Renamed and added new messages for roles.
.../InfoCard/InfoCard.tsx Localized strings using formatMessage.
.../InfoCard/InfoCardActiveIndictment.tsx Updated string references and imports.
.../InfoCard/InfoCardCaseScheduled.strings.ts Introduced internationalization messages.
.../InfoCard/InfoCardCaseScheduled.tsx Updated imports and removed postponedIndefinitelyExplanation prop.
.../InfoCard/InfoCardCaseScheduledIndictment.strings.ts New file with messages for postponed cases.
.../InfoCard/InfoCardCaseScheduledIndictment.tsx New component for displaying scheduled indictment cases.
.../InfoCard/InfoCardClosedIndictment.tsx Adjusted imports and string references.
.../InfoCard/InfoCardIndictment.strings.ts Defined messages for indictment information.
.../components/index.ts Added exports for new components.
.../routes/.../Overview.tsx (multiple) Removed outdated prop and adjusted imports.
.../routes/Shared/IndictmentOverview/IndictmentOverview.tsx Updated imports and variable references.

This table summarizes the changes made to the codebase, emphasizing the shift towards better localization and code clarity.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@datadog-island-is
Copy link

datadog-island-is bot commented May 1, 2024

Datadog Report

All test runs 4f7709b 🔗

2 Total Test Services: 0 Failed, 2 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.03%), 1 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Code Coverage Change Test Service View
judicial-system-web 0 0 0 311 0 45.46s 1 increased (+0.03%) Link
web 0 0 0 84 0 3.28s 1 no change Link

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 37.09%. Comparing base (1d471e0) to head (3f785cb).
Report is 1 commits behind head on main.

❗ Current head 3f785cb differs from pull request most recent head 1da3fc0. Consider uploading reports for the commit 1da3fc0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #14655   +/-   ##
=======================================
  Coverage   37.09%   37.09%           
=======================================
  Files        6240     6244    +4     
  Lines      126403   126394    -9     
  Branches    36162    36155    -7     
=======================================
+ Hits        46885    46889    +4     
+ Misses      79518    79505   -13     
Flag Coverage Δ
judicial-system-web 28.67% <47.36%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...em/web/src/components/InfoCard/InfoCard.strings.ts 100.00% <100.00%> (ø)
...c/components/InfoCard/InfoCardActiveIndictment.tsx 10.00% <ø> (+1.66%) ⬆️
...mponents/InfoCard/InfoCardCaseScheduled.strings.ts 100.00% <100.00%> (ø)
...nfoCard/InfoCardCaseScheduledIndictment.strings.ts 100.00% <100.00%> (ø)
...c/components/InfoCard/InfoCardClosedIndictment.tsx 6.25% <ø> (+0.69%) ⬆️
.../components/InfoCard/InfoCardIndictment.strings.ts 100.00% <100.00%> (ø)
...utes/Court/InvestigationCase/Overview/Overview.tsx 0.00% <ø> (ø)
...routes/Court/RestrictionCase/Overview/Overview.tsx 0.00% <ø> (ø)
...al-system/web/src/routes/Defender/CaseOverview.tsx 0.00% <ø> (ø)
...Prosecutor/InvestigationCase/Overview/Overview.tsx 0.00% <ø> (ø)
... and 5 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d151247...1da3fc0. Read the comment docs.

Copy link
Member

@unakb unakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice cleanup!

@oddsson oddsson added the automerge Merge this PR as soon as all checks pass label May 2, 2024
@kodiakhq kodiakhq bot merged commit de534c8 into main May 2, 2024
26 checks passed
@kodiakhq kodiakhq bot deleted the j-s/indefinite-postponement-infocard branch May 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants