fix(auth-react): Remove auth-react library in favour of bff #17102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes in this pull request involve the deletion of several configuration and implementation files related to the Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (34)
💤 Files with no reviewable changes (34)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
snaerth
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17102 +/- ##
==========================================
- Coverage 35.76% 35.72% -0.04%
==========================================
Files 6931 6931
Lines 147949 148388 +439
Branches 42167 42392 +225
==========================================
+ Hits 52917 53019 +102
- Misses 95032 95369 +337 Flags with carried forward coverage won't be shown. Click here to find out more. see 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 98 Total Test Services: 0 Failed, 90 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
oddsson
approved these changes
Dec 2, 2024
eirikurn
approved these changes
Dec 3, 2024
thorhildurt
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: snaerseljan <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove auth-react library in favour of bff
What
Remove
auth-reactlibraryWhy
Bff auth system is replacing auth
Checklist:
Summary by CodeRabbit
Chores
README.mddocumentation for the authentication library, which provided usage and setup instructions.@island.is/auth/reactmodule from the Storybook configuration.@island.is/auth/reactin the TypeScript base configuration.Bug Fixes