feat(j-s): Notifications sent when court officials are assigned #17169
+123
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…officials-notifications
WalkthroughThis pull request introduces enhancements to the notification system within the judicial application. It adds a new message group for court official assignments, updates notification rules for judges and registrars, and introduces new methods to send notifications when these officials are assigned to cases. Additionally, new notification types are added to the relevant enums, ensuring that the system can correctly handle and dispatch notifications related to case assignments for district court judges and registrars. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
👮 Files not reviewed due to content moderation or server errors (3)
🧰 Additional context used📓 Path-based instructions (3)apps/judicial-system/backend/src/app/modules/notification/guards/rolesRules.ts (1)Pattern
apps/judicial-system/backend/src/app/modules/notification/services/caseNotification/caseNotification.service.ts (1)Pattern
apps/judicial-system/backend/src/app/modules/case/case.service.ts (1)Pattern
📓 Learnings (2)apps/judicial-system/backend/src/app/modules/notification/guards/rolesRules.ts (1)apps/judicial-system/backend/src/app/modules/notification/services/caseNotification/caseNotification.service.ts (3)Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…officials-notifications
oddsson
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17169 +/- ##
==========================================
- Coverage 35.74% 35.73% -0.01%
==========================================
Files 6937 6937
Lines 148255 148284 +29
Branches 42297 42311 +14
==========================================
+ Hits 52989 52995 +6
- Misses 95266 95289 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 18 Total Test Services: 0 Failed, 17 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
thorhildurt
reviewed
Dec 11, 2024
apps/judicial-system/backend/src/app/modules/case/case.service.ts
Outdated
Show resolved
Hide resolved
apps/judicial-system/backend/src/app/modules/case/case.service.ts
Outdated
Show resolved
Hide resolved
...m/backend/src/app/modules/notification/services/caseNotification/caseNotification.service.ts
Outdated
Show resolved
Hide resolved
...m/backend/src/app/modules/notification/services/caseNotification/caseNotification.service.ts
Outdated
Show resolved
Hide resolved
…officials-notifications
…-is/island.is into j-s/court-officials-notifications
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/judicial-system/backend/src/app/modules/case/case.service.ts (1)
1415-1437: Consider using more descriptive boolean variable namesThe boolean variables could be more descriptive by using the "is" prefix to better indicate their purpose.
Apply this diff to improve variable naming:
- const judgeChanged = + const isJudgeChanged = updatedCase.judge?.nationalId !== theCase.judge?.nationalId - const registrarChanged = + const isRegistrarChanged = updatedCase.registrar?.nationalId !== theCase.registrar?.nationalId - if (judgeChanged) { + if (isJudgeChanged) { await this.addMessagesForDistrictCourtJudgeAssignedToQueue( updatedCase, user, ) } - if (registrarChanged) { + if (isRegistrarChanged) { await this.addMessagesForDistrictCourtRegistrarAssignedToQueue( updatedCase, user, ) }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/judicial-system/backend/src/app/messages/notifications.ts(1 hunks)apps/judicial-system/backend/src/app/modules/case/case.service.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/judicial-system/backend/src/app/messages/notifications.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/case.service.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (3)
apps/judicial-system/backend/src/app/modules/case/case.service.ts (2)
689-701: LGTM! Clean implementation of judge notification
The method follows the established pattern for notification handling and uses the correct notification type.
703-715: LGTM! Clean implementation of registrar notification
The method follows the established pattern for notification handling and uses the correct notification type.
apps/judicial-system/backend/src/app/messages/notifications.ts (1)
859-873: LGTM with a minor formatting suggestion!
The new message group for court official notifications is well-structured and properly internationalized. The implementation:
- Uses correct message ID namespacing
- Provides clear descriptions for translators
- Handles role-specific text appropriately
- Maintains consistency with existing message patterns
Consider adding a space before the link text for better readability:
- 'Héraðsdómur hefur skráð þig sem {role, select, DISTRICT_COURT_JUDGE {dómara} DISTRICT_COURT_REGISTRAR {dómritara} other {óþekkt}} í máli {courtCaseNumber}. Hægt er að nálgast gögn málsins á {linkStart}yfirlitssíðu málsins í Réttarvörslugátt{linkEnd}',
+ 'Héraðsdómur hefur skráð þig sem {role, select, DISTRICT_COURT_JUDGE {dómara} DISTRICT_COURT_REGISTRAR {dómritara} other {óþekkt}} í máli {courtCaseNumber}. Hægt er að nálgast gögn málsins á {linkStart}yfirlitssíðu málsins í Réttarvörslugátt {linkEnd}',
gudjong
requested changes
Dec 13, 2024
apps/judicial-system/backend/src/app/modules/notification/guards/rolesRules.ts
Outdated
Show resolved
Hide resolved
apps/judicial-system/backend/src/app/modules/notification/guards/rolesRules.ts
Outdated
Show resolved
Hide resolved
apps/judicial-system/backend/src/app/modules/notification/notification.service.ts
Outdated
Show resolved
Hide resolved
…-is/island.is into j-s/court-officials-notifications
…officials-notifications
gudjong
approved these changes
Dec 14, 2024
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications sent when court officials are assigned
Asana
What
Send notifications to judges and registrars when they are assigned to a case.
Why
This is done to inform those users about the cases they are responsible for.
Checklist:
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Chores