Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user-notification): Firebase Credentials Setup for Local Development #17199

Merged
merged 13 commits into from
Dec 13, 2024
Merged

feat(user-notification): Firebase Credentials Setup for Local Development #17199

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6e33010
fix get-secrets and env cleanup
rafnarnason Dec 11, 2024
09c583c
chore: nx format:write update dirty files
andes-it Dec 11, 2024
1128ee5
string cleaner for local
rafnarnason Dec 11, 2024
11755e8
Merge branch 'user-notification/update-readme-env' of https://github.…
rafnarnason Dec 11, 2024
a81371c
chore: nx format:write update dirty files
andes-it Dec 11, 2024
4503975
update get-secrets
rafnarnason Dec 11, 2024
1a0ce36
Merge branch 'user-notification/update-readme-env' of https://github.…
rafnarnason Dec 11, 2024
d32d5ba
cleanup
rafnarnason Dec 11, 2024
6b9c861
cleanup
rafnarnason Dec 11, 2024
dcb7b00
Merge branch 'main' into user-notification/update-readme-env
rafnarnason Dec 12, 2024
8a9876a
move logic to render-secrets
rafnarnason Dec 12, 2024
f6757d8
Merge branch 'user-notification/update-readme-env' of https://github.…
rafnarnason Dec 12, 2024
72ccdf2
Merge branch 'main' into user-notification/update-readme-env
kodiakhq[bot] Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions infra/src/cli/render-secrets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@ export const renderSecrets = async (service: string) => {

logger.debug('env when rendering', { envMap })
Object.entries(envMap).forEach(([key, value]) => {
const escapedValue = (value ?? '')
.replace(/\n/g, '\\n')
.replace(/"/g, '\\"')
const escapedValue = (value ?? '').replace(/'/g, "\\'")
console.log(`export ${key}='${escapedValue}'`)
rafnarnason marked this conversation as resolved.
Show resolved Hide resolved
})
return envMap
Expand Down
Loading