Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): new header for Rannis org page #17208

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

disaerna
Copy link
Member

@disaerna disaerna commented Dec 11, 2024

Organization - Rannis - Web

What

Add custom header for Rannís

Why

Beautiful ✨

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Introduced a new 'rannis' theme for the OrganizationHeader component, featuring a linear gradient background.
  • Bug Fixes

    • Ensured existing themes continue to render correctly without disruption.

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Walkthrough

The pull request introduces a new theme case for 'rannis' within the OrganizationHeader component. This modification allows the DefaultHeader to be rendered with a specific linear gradient background when the 'rannis' theme is selected. The change extends the existing theming logic without altering the overall component structure or modifying any public entity signatures.

Changes

File Change Summary
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx Added theme handling for 'rannis' theme in OrganizationHeader, implementing a linear gradient background for the DefaultHeader

Sequence Diagram

sequenceDiagram
    participant OrganizationWrapper
    participant OrganizationHeader
    participant DefaultHeader

    OrganizationWrapper->>OrganizationHeader: Render with theme
    alt Theme is 'rannis'
        OrganizationHeader-->>DefaultHeader: Apply linear gradient background
    else Other themes
        OrganizationHeader-->>DefaultHeader: Use default rendering
    end
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.70%. Comparing base (b280879) to head (42472d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nents/Organization/Wrapper/OrganizationWrapper.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17208      +/-   ##
==========================================
- Coverage   35.73%   35.70%   -0.03%     
==========================================
  Files        6941     6941              
  Lines      148406   148411       +5     
  Branches    42340    42339       -1     
==========================================
- Hits        53037    52995      -42     
- Misses      95369    95416      +47     
Flag Coverage Δ
api 3.33% <ø> (ø)
api-domains-auth-admin 48.49% <ø> (ø)
api-domains-communications 39.41% <ø> (ø)
application-system-api 38.74% <ø> (+0.01%) ⬆️
application-template-api-modules 27.82% <ø> (-0.01%) ⬇️
cms 0.39% <ø> (ø)
cms-translations 38.74% <ø> (ø)
judicial-system-api 20.21% <ø> (ø)
judicial-system-backend 55.90% <ø> (ø)
services-user-notification 46.54% <ø> (ø)
web 2.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nents/Organization/Wrapper/OrganizationWrapper.tsx 0.00% <0.00%> (ø)

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b280879...42472d9. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Dec 11, 2024

Datadog Report

All test runs 7838c3c 🔗

28 Total Test Services: 0 Failed, 26 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.01%), 115 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-web 0 0 0 2 0 6.77s 1 no change Link
api 0 0 0 4 0 3.21s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 14.98s 1 no change Link
api-domains-communications 0 0 0 5 0 40.4s 1 no change Link
api-domains-license-service 0 0 0 0 0 536.57ms 1 no change Link
application-api-files 0 0 0 2 0 4.33s 1 no change Link
application-core 0 0 0 97 0 15.14s 1 no change Link
application-system-api 0 0 0 46 0 2m 12.32s 1 no change Link
application-template-api-modules 0 0 0 118 0 2m 7.26s 1 decreased (-0.01%) Link
application-templates-accident-notification 0 0 0 148 0 18.38s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (1)

  • application-template-api-modules - jest 30.2% (-0.01%) - Details

@disaerna disaerna marked this pull request as ready for review December 12, 2024 09:07
@disaerna disaerna requested review from a team as code owners December 12, 2024 09:07
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)

621-627: LGTM! Consider extracting the gradient as a constant.

The implementation for the 'rannis' theme case is correct and follows the established pattern. The gradient colors are properly defined and the DefaultHeader component is used consistently.

Consider extracting the gradient to a constant at the top of the file for better maintainability:

+const RANNIS_HEADER_GRADIENT = "linear-gradient(271deg, #C00B02 5.72%, #DB0B00 91.04%)"

 case 'rannis':
   return (
     <DefaultHeader
       {...defaultProps}
-      background="linear-gradient(271deg, #C00B02 5.72%, #DB0B00 91.04%)"
+      background={RANNIS_HEADER_GRADIENT}
     />
   )
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b11b2e1 and 127a7e9.

⛔ Files ignored due to path filters (1)
  • libs/cms/src/lib/generated/contentfulTypes.d.ts is excluded by !**/generated/**
📒 Files selected for processing (1)
  • apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."

@disaerna disaerna removed the request for review from a team December 17, 2024 12:19
@disaerna disaerna added the automerge Merge this PR as soon as all checks pass label Dec 17, 2024
@kodiakhq kodiakhq bot merged commit c07421f into main Dec 17, 2024
64 checks passed
@kodiakhq kodiakhq bot deleted the feature/web-rannis-header branch December 17, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants