-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): new header for Rannis org page #17208
Conversation
WalkthroughThe pull request introduces a new theme case for 'rannis' within the Changes
Sequence DiagramsequenceDiagram
participant OrganizationWrapper
participant OrganizationHeader
participant DefaultHeader
OrganizationWrapper->>OrganizationHeader: Render with theme
alt Theme is 'rannis'
OrganizationHeader-->>DefaultHeader: Apply linear gradient background
else Other themes
OrganizationHeader-->>DefaultHeader: Use default rendering
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17208 +/- ##
==========================================
- Coverage 35.73% 35.70% -0.03%
==========================================
Files 6941 6941
Lines 148406 148411 +5
Branches 42340 42339 -1
==========================================
- Hits 53037 52995 -42
- Misses 95369 95416 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 28 Total Test Services: 0 Failed, 26 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)
621-627
: LGTM! Consider extracting the gradient as a constant.The implementation for the 'rannis' theme case is correct and follows the established pattern. The gradient colors are properly defined and the DefaultHeader component is used consistently.
Consider extracting the gradient to a constant at the top of the file for better maintainability:
+const RANNIS_HEADER_GRADIENT = "linear-gradient(271deg, #C00B02 5.72%, #DB0B00 91.04%)" case 'rannis': return ( <DefaultHeader {...defaultProps} - background="linear-gradient(271deg, #C00B02 5.72%, #DB0B00 91.04%)" + background={RANNIS_HEADER_GRADIENT} /> )
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
libs/cms/src/lib/generated/contentfulTypes.d.ts
is excluded by!**/generated/**
📒 Files selected for processing (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)
Pattern apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Organization - Rannis - Web
What
Add custom header for Rannís
Why
Beautiful ✨
Checklist:
Summary by CodeRabbit
New Features
OrganizationHeader
component, featuring a linear gradient background.Bug Fixes