fix(web): Sort by title for generic list and team list #17226
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
libs/cms/src/lib/cms.elasticsearch.service.ts (2)
528-535: LGTM! The sorting implementation correctly restores the title sorting feature.The implementation properly sorts items first by release date (descending) and then by title (ascending) for items with equal release dates, which aligns with the PR objective to reintroduce the title sorting feature.
Consider extracting the sort configuration into a constant to improve reusability:
+const DEFAULT_LIST_SORT: sortRule[] = [ + { + [SortField.RELEASE_DATE]: { + order: SortDirection.DESC, + }, + }, + { 'title.sort': { order: SortDirection.ASC } }, +]; - const sort: sortRule[] = [ - { - [SortField.RELEASE_DATE]: { - order: SortDirection.DESC, - }, - }, - { 'title.sort': { order: SortDirection.ASC } }, - ] + const sort = DEFAULT_LIST_SORT;
534-535: Enhance the comment to cover both sorting criteria.The comment could be more comprehensive by mentioning both sorting criteria.
- // Sort items with equal values by ascending title order + // Sort items by release date (DESC), then by title (ASC) for items with equal dates
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/cms/src/lib/cms.elasticsearch.service.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/cms/src/lib/cms.elasticsearch.service.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17226 +/- ##
=======================================
Coverage 35.75% 35.75%
=======================================
Files 6935 6935
Lines 148113 148113
Branches 42233 42233
=======================================
Hits 52953 52953
Misses 95160 95160
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 9 Passed Test ServicesThis report shows up to 10 services
|
Sort by title for generic list and team list
What
Why
This feature was present previously, here I am adding it in again
Screenshots / Gifs
Before
After
Checklist:
Summary by CodeRabbit