feat(income-plan): Remove edit function after submission

[ylfahfa]

Remove edit functionality

What

Don't allow applicant to edit application after submission

Why

To simplify the process

Screenshots / Gifs

Remove this button and edit functionality

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Simplified user interface by removing the "Edit" button from the income plan review process.
  • Updated messaging to reflect that the income plan is awaiting review.

• Bug Fixes

  • Streamlined role capabilities for applicants in the submitted state, eliminating unnecessary editing actions.

• Documentation

  • Updated message descriptors to clarify the editing status of the income plan during the review process.

[coderabbitai]

Walkthrough

The pull request introduces changes to the income plan module, specifically removing the ability for applicants to edit their income plan after submission to Tryggingastofnun. The modifications span across multiple files, including the Review component, IncomePlanTemplate, and messages.ts. The primary focus is on simplifying the user interface and state management by eliminating the edit functionality for applications in the TRYGGINGASTOFNUN_SUBMITTED state.

Changes

File	Change Summary
libs/application/templates/social-insurance-administration/income-plan/src/fields/Review/index.tsx	Removed "Edit" button for TRYGGINGASTOFNUN_SUBMITTED application state.
libs/application/templates/social-insurance-administration/income-plan/src/lib/IncomePlanTemplate.ts	Eliminated EDIT event action and state transition for applicant in TRYGGINGASTOFNUN_SUBMITTED state.
libs/application/templates/social-insurance-administration/income-plan/src/lib/messages.ts	Removed buttonEdit message descriptor and simplified tryggingastofnunSubmittedContent message.
libs/application/templates/social-insurance-administration/income-plan/src/lib/IncomePlanTemplate.spec.ts	Removed test case for transition from TRYGGINGASTOFNUN_SUBMITTED to DRAFT on edit event.

Possibly related PRs

• feat(income-plan): add year #15847: This PR modifies the messages.ts file, which is relevant to the income plan module, similar to the main PR's changes in the same file regarding the removal of the "Edit" button and related messages.
• fix(income-plan): Hide IKR when foreign income #15987: This PR also deals with the IncomePlanForm.ts file, where changes to the handling of income types are made, which could relate to the overall functionality of the income plan as described in the main PR.
• feat(income-plan): Only allow one income plan in draft #15998: This PR introduces a restriction on draft applications in the IncomePlanTemplate, which aligns with the main PR's focus on simplifying the user interface by removing the "Edit" button.
• feat(income-plan): Update updateValueObj in incomeType #15999: This PR updates the IncomePlanForm.ts file, which is directly related to the main PR's modifications in the same file, focusing on the handling of income types and their associated logic.
• fix(income-plan): amend dynamic eligible messages #16918: This PR modifies the IncomePlanForm.ts file to enhance eligibility messaging, which is relevant to the main PR's focus on the income plan's user interface and functionality.
• feat(income-plan): Use new temporary income plan calculation data #16933: This PR introduces new components and fields in the IncomePlanForm.ts, which is directly related to the main PR's changes in the same file, enhancing user interaction regarding income plans.
• fix(efs): taxfree value spouse percentage #17002: This PR focuses on the HeirsRepeater component, which, while not directly related to the main PR, still falls under the broader context of income and inheritance management within the application.
• feat(old-age-pension): Show conclusion page based on income plan status #17087: This PR introduces a conclusion page based on income plan status, which is relevant to the main PR's focus on the income plan's user interface and functionality.

Suggested reviewers

• thorkellmani

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7dd5c12 and 2347268.

📒 Files selected for processing (1)

• libs/application/templates/social-insurance-administration/income-plan/src/lib/IncomePlanTemplate.spec.ts (0 hunks)

💤 Files with no reviewable changes (1)

• libs/application/templates/social-insurance-administration/income-plan/src/lib/IncomePlanTemplate.spec.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.73%. Comparing base (0c7df8f) to head (5915052).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17246   +/-   ##
=======================================
  Coverage   35.73%   35.73%           
=======================================
  Files        6938     6938           
  Lines      148305   148305           
  Branches    42316    42316           
=======================================
  Hits        52999    52999           
  Misses      95306    95306           

Flag	Coverage Δ
api	3.33% <ø> (ø)
application-system-api	38.75% <ø> (+<0.01%)	⬆️
application-template-api-modules	27.80% <ø> (-0.03%)	⬇️
application-ui-shell	22.45% <ø> (ø)
web	2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...stration/income-plan/src/lib/IncomePlanTemplate.ts	14.85% <ø> (ø)
...nce-administration/income-plan/src/lib/messages.ts	100.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7df8f...5915052. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 9fbe3ae 🔗

✅ 5 Total Test Services: 0 Failed, 5 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.11%), 8 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.97s	1 no change	Link
application-system-api	0	0	0	46	0	2m 25.93s	1 no change	Link
application-template-api-modules	0	0	0	118	0	2m 22.77s	1 no change	Link
application-ui-shell	0	0	0	74	0	32.11s	1 no change	Link
web	0	0	0	84	0	31.8s	1 no change	Link

[helgifr]

LGTM