feat(new-primary-school): Add mock users for testing application hotfix (#17220) #17252

helgifr · 2024-12-16T14:02:17Z

feat(new-primary-school): Add mock users for testing application
remove console log
Removed mock user file

Co-authored-by: hfhelgason [email protected]
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

…ix (#17220) * feat(new-primary-school): Add mock users for testing application * remove console log * Removed mock user file --------- Co-authored-by: hfhelgason <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

coderabbitai · 2024-12-16T14:02:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

birkirkristmunds

LGTM

github-actions · 2024-12-16T14:35:51Z

Deployed services: application-system-api,api,application-system-api-worker,consultation-portal,web,services-bff-portals-admin,services-bff-portals-my-pages.
Excluded services: ``

datadog-island-is · 2024-12-16T14:39:03Z

Datadog Report

All test runs ffb0ef8 🔗

✅ 3 Total Test Services: 0 Failed, 3 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.01%), 3 no change

Test Services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`api`	4	3.21s	1 no change	Link
`application-system-api`	46	2m 27.46s	1 no change	Link
`application-template-api-modules`	118	2m 38.23s	1 decreased (-0.01%)	Link

🔻 Code Coverage Decreases vs Default Branch (1)

application-template-api-modules - jest 30.2% (-0.01%) - Details

codecov · 2024-12-16T14:42:02Z

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.71%. Comparing base (f567a35) to head (f54e48f).
Report is 3 commits behind head on release/33.2.0.

Files with missing lines	Patch %	Lines
...s/new-primary-school/new-primary-school.service.ts	12.50%	7 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##           release/33.2.0   #17252      +/-   ##
==================================================
- Coverage           35.71%   35.71%   -0.01%     
==================================================
  Files                6928     6928              
  Lines              147900   147908       +8     
  Branches            42179    42183       +4     
==================================================
+ Hits                52828    52829       +1     
- Misses              95072    95079       +7

Flag	Coverage Δ
api	`3.33% <ø> (ø)`
application-system-api	`38.75% <12.50%> (-0.01%)`	⬇️
application-template-api-modules	`27.81% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/new-primary-school/new-primary-school.service.ts	`31.48% <12.50%> (-3.31%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f567a35...f54e48f. Read the comment docs.

helgifr requested a review from a team as a code owner December 16, 2024 14:02

helgifr added the automerge Merge this PR as soon as all checks pass label Dec 16, 2024

birkirkristmunds approved these changes Dec 16, 2024

View reviewed changes

helgifr added deploy-feature Deploys features to dev and removed automerge Merge this PR as soon as all checks pass labels Dec 16, 2024

helgifr closed this Dec 16, 2024

helgifr deleted the hotfix/mock-users-for-new-primary-school-application branch December 16, 2024 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(new-primary-school): Add mock users for testing application hotfix (#17220) #17252

feat(new-primary-school): Add mock users for testing application hotfix (#17220) #17252

helgifr commented Dec 16, 2024

coderabbitai bot commented Dec 16, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

birkirkristmunds left a comment

github-actions bot commented Dec 16, 2024

datadog-island-is bot commented Dec 16, 2024

codecov bot commented Dec 16, 2024 •

edited

Loading

feat(new-primary-school): Add mock users for testing application hotfix (#17220) #17252

feat(new-primary-school): Add mock users for testing application hotfix (#17220) #17252

Conversation

helgifr commented Dec 16, 2024

...

What

Why

Screenshots / Gifs

Checklist:

coderabbitai bot commented Dec 16, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

birkirkristmunds left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 16, 2024

datadog-island-is bot commented Dec 16, 2024

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (1)

codecov bot commented Dec 16, 2024 • edited Loading

Codecov Report

codecov bot commented Dec 16, 2024 •

edited

Loading