Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(my-pages): Remove health doc button #17261

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

thordurhhh
Copy link
Member

@thordurhhh thordurhhh commented Dec 16, 2024

What

remove health doc button

Why

not used anymore

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • No new features introduced.
  • Bug Fixes

    • No bug fixes addressed.
  • Refactor

    • Simplified the PaymentOverview component by removing the document fetching functionality and related imports.
  • Chores

    • Removed the HealthPaymentsOverviewController class, streamlining the handling of health payment overview documents.

@thordurhhh thordurhhh added the automerge Merge this PR as soon as all checks pass label Dec 16, 2024
@thordurhhh thordurhhh requested a review from a team as a code owner December 16, 2024 15:37
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

Walkthrough

The pull request involves the removal of the HealthPaymentsOverviewController from the download service and modifications to the PaymentOverview component in the health portal. These changes eliminate the functionality for fetching and downloading health payment overview documents, suggesting a redesign or deprecation of the document retrieval feature. Corresponding adjustments to the frontend component have been made to remove related UI elements and methods.

Changes

File Change Summary
apps/download-service/src/app/modules/health/payment-overview-documents.controller.ts Entire controller removed, eliminating the endpoint for retrieving health payment overview PDFs.
libs/portals/my-pages/health/src/screens/Payments/PaymentOverview.tsx Removed onFetchDocument method, deleted document fetching button, and removed "Payment Document" header from table.
apps/download-service/src/app/app.module.ts Removed HealthPaymentsOverviewController from the controllers array in the AppModule.

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32a135f and aa4c5ed.

📒 Files selected for processing (1)
  • apps/download-service/src/app/app.module.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/download-service/src/app/app.module.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.72%. Comparing base (59f9dd0) to head (aa4c5ed).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17261      +/-   ##
==========================================
- Coverage   35.72%   35.72%   -0.01%     
==========================================
  Files        6939     6939              
  Lines      148369   148368       -1     
  Branches    42325    42325              
==========================================
- Hits        53010    53009       -1     
  Misses      95359    95359              
Flag Coverage Δ
api 3.33% <ø> (ø)
application-system-api 38.74% <ø> (ø)
application-template-api-modules 27.83% <ø> (ø)
application-ui-shell 22.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/download-service/src/app/app.module.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f9dd0...aa4c5ed. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 1ff8a2a 🔗

5 Total Test Services: 0 Failed, 4 Passed
➡️ Test Sessions change in coverage: 10 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.91s 1 no change Link
application-system-api 0 0 0 46 0 2m 23.89s 1 no change Link
application-template-api-modules 0 0 0 118 0 2m 28.21s 1 no change Link
application-ui-shell 0 0 0 74 0 33.42s 1 no change Link
download-service 0 0 0 0 0 570.72ms 1 no change Link

@kodiakhq kodiakhq bot merged commit c3e8a9e into main Dec 17, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the my-pages/health-payment-button branch December 17, 2024 09:53
thordurhhh added a commit that referenced this pull request Dec 17, 2024
* remove button

* Remove unused import

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants