Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(my-pages-assets): HOTFIX - add charts to vehicle mileage screens #17298

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

thorkellmani
Copy link
Member

@thorkellmani thorkellmani commented Dec 19, 2024

HOTFIX

#17203
#17289
#17228

What

  • Add charts to My Pages
  • Show charts on VehicleMileage and VehicleBulkMileage expandable row
  • Add back "other" for organ donation registration

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

thorkellmani and others added 2 commits December 19, 2024 13:19
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Copy link
Contributor

coderabbitai bot commented Dec 19, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thorkellmani thorkellmani added the automerge Merge this PR as soon as all checks pass label Dec 19, 2024
@thorkellmani thorkellmani marked this pull request as ready for review December 19, 2024 13:24
@thorkellmani thorkellmani requested review from a team as code owners December 19, 2024 13:24
)

* feat: add back "other" for organ donation registration

* refactor: update api client for organ donations

* refactor: texts

* fix: as

* fix: type safety

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@datadog-island-is
Copy link

datadog-island-is bot commented Dec 19, 2024

Datadog Report

All test runs 9af56a3 🔗

10 Total Test Services: 0 Failed, 10 Passed
🔻 Test Sessions change in coverage: 11 decreased, 28 increased, 161 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 63 0 28.73s N/A Link
air-discount-scheme-web 0 0 0 2 0 7.02s N/A Link
api 0 0 0 4 0 2.4s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 16s N/A Link
api-domains-assets 0 0 0 3 0 9.65s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 10.43s N/A Link
api-domains-communications 0 0 0 5 0 29.47s 1 increased (+0.08%) Link
api-domains-criminal-record 0 0 0 5 0 8.33s 1 increased (+0.08%) Link
api-domains-driving-license 0 0 0 23 0 26.29s 1 no change Link
api-domains-education 0 0 0 8 0 17.54s 1 increased (+0.07%) Link

🔻 Code Coverage Decreases vs Default Branch (11)

This report shows up to 5 code coverage decreases.

  • clients-financial-statements-inao - jest 49.75% (-2.11%) - Details
  • judicial-system-xrd-api - jest 74.63% (-0.17%) - Details
  • application-templates-marriage-conditions - jest 19.78% (-0.11%) - Details
  • judicial-system-scheduler - jest 76.66% (-0.1%) - Details
  • judicial-system-backend - jest 59.45% (-0.09%) - Details

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (ad91967) to head (26d6993).
Report is 3 commits behind head on release/33.2.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/33.2.0   #17298      +/-   ##
==================================================
- Coverage           35.71%   35.71%   -0.01%     
==================================================
  Files                6929     6930       +1     
  Lines              147899   147917      +18     
  Branches            42167    42180      +13     
==================================================
+ Hits                52827    52831       +4     
- Misses              95072    95086      +14     
Flag Coverage Δ
air-discount-scheme-backend 48.25% <100.00%> (+0.01%) ⬆️
air-discount-scheme-web 0.00% <ø> (ø)
api 3.33% <ø> (ø)
api-domains-air-discount-scheme 37.96% <100.00%> (+0.02%) ⬆️
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.49% <ø> (ø)
api-domains-communications 39.43% <100.00%> (-0.02%) ⬇️
api-domains-criminal-record 48.02% <100.00%> (+0.03%) ⬆️
api-domains-driving-license 44.85% <100.00%> (+0.01%) ⬆️
api-domains-education 31.26% <100.00%> (+0.03%) ⬆️
api-domains-health-insurance 35.41% <100.00%> (+0.04%) ⬆️
api-domains-mortgage-certificate 35.21% <100.00%> (+0.02%) ⬆️
api-domains-payment-schedule 42.10% <100.00%> (+0.02%) ⬆️
application-api-files 61.90% <100.00%> (+0.03%) ⬆️
application-core 76.01% <ø> (ø)
application-system-api 38.76% <100.00%> (-0.01%) ⬇️
application-template-api-modules 27.81% <100.00%> (-0.01%) ⬇️
application-templates-accident-notification 28.93% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.78% <ø> (ø)
application-templates-driving-license 18.12% <ø> (ø)
application-templates-estate 13.79% <ø> (ø)
application-templates-example-payment 24.71% <ø> (ø)
application-templates-financial-aid 14.42% <ø> (ø)
application-templates-general-petition 23.13% <ø> (ø)
application-templates-inheritance-report 6.54% <ø> (ø)
application-templates-marriage-conditions 15.11% <ø> (ø)
application-templates-mortgage-certificate 43.56% <ø> (ø)
application-templates-parental-leave 29.95% <ø> (+0.11%) ⬆️
application-types 6.57% <ø> (ø)
application-ui-components 1.24% <ø> (ø)
application-ui-shell 22.47% <ø> (ø)
clients-charge-fjs-v2 28.35% <ø> (ø)
clients-driving-license 40.87% <100.00%> (+0.03%) ⬆️
clients-driving-license-book 43.90% <100.00%> (+0.02%) ⬆️
clients-financial-statements-inao 47.28% <100.00%> (+0.03%) ⬆️
clients-license-client 1.26% <ø> (ø)
clients-regulations 42.97% <100.00%> (+0.04%) ⬆️
clients-rsk-company-registry 31.14% <ø> (ø)
clients-rsk-personal-tax-return 39.02% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.47% <100.00%> (+0.02%) ⬆️
clients-zendesk 50.82% <100.00%> (+0.11%) ⬆️
cms 0.40% <ø> (-0.01%) ⬇️
cms-translations 38.77% <100.00%> (-0.02%) ⬇️
contentful-apps 4.71% <ø> (-0.01%) ⬇️
dokobit-signing 62.52% <100.00%> (+0.08%) ⬆️
email-service 60.43% <100.00%> (+0.07%) ⬆️
feature-flags 90.76% <100.00%> (+0.07%) ⬆️
file-storage 46.13% <100.00%> (+0.10%) ⬆️
financial-aid-backend 51.45% <100.00%> (+0.01%) ⬆️
judicial-system-api 19.97% <ø> (ø)
judicial-system-audit-trail 68.94% <100.00%> (+0.08%) ⬆️
judicial-system-backend 55.75% <100.00%> (-0.02%) ⬇️
judicial-system-message 66.72% <100.00%> (+0.06%) ⬆️
judicial-system-message-handler 48.30% <100.00%> (+0.08%) ⬆️
judicial-system-scheduler 70.90% <100.00%> (+0.02%) ⬆️
license-api 43.00% <100.00%> (-0.01%) ⬇️
nest-config 77.03% <100.00%> (+0.06%) ⬆️
nest-feature-flags 51.19% <100.00%> (+0.06%) ⬆️
nova-sms 61.87% <100.00%> (+0.09%) ⬆️
portals-admin-regulations-admin 1.80% <ø> (ø)
portals-core 19.83% <ø> (ø)
services-auth-admin-api 52.57% <100.00%> (+<0.01%) ⬆️
services-auth-delegation-api 58.55% <100.00%> (+0.08%) ⬆️
services-auth-ids-api 52.54% <100.00%> (+0.01%) ⬆️
services-auth-public-api 49.42% <100.00%> (+0.01%) ⬆️
services-sessions 65.46% <100.00%> (+0.01%) ⬆️
services-university-gateway 49.56% <100.00%> (+0.04%) ⬆️
services-user-notification 46.58% <100.00%> (-0.03%) ⬇️
services-user-profile 56.94% <100.00%> (-0.08%) ⬇️
web 2.42% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libs/feature-flags/src/lib/features.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad91967...26d6993. Read the comment docs.

Copy link
Member

@thordurhhh thordurhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@kodiakhq kodiakhq bot merged commit 9dd9a33 into release/33.2.0 Dec 19, 2024
209 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-charts-to-my-oages branch December 19, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants