Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Uni pr" #17309

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Revert "Uni pr" #17309

merged 1 commit into from
Dec 20, 2024

Conversation

robertaandersen
Copy link
Member

@robertaandersen robertaandersen commented Dec 20, 2024

Reverts #17308

Summary by CodeRabbit

Release Notes

  • New Features

    • Simplified workflow triggers for pull requests, allowing all branches to trigger workflows without exclusions.
    • Added manual triggering capability for workflows.
  • Bug Fixes

    • Improved error handling in workflows for better management of pull request failures.
  • Chores

    • Removed obsolete unicorn-app service configurations from various YAML files.
    • Cleaned up multiple configuration files related to the unicorn-app, enhancing overall project organization.

This reverts commit 19553a3.
@robertaandersen robertaandersen requested review from a team as code owners December 20, 2024 10:34
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves a comprehensive removal of the unicorn-app from the project's infrastructure. The changes span multiple configuration files across GitHub Actions workflows, Kubernetes charts, TypeScript configurations, and project-specific settings. The primary focus is on completely eliminating references to the unicorn-app, including its deployment configurations, workflow triggers, and associated scripts. The modifications suggest a strategic decision to remove this application from the project's ecosystem.

Changes

File/Directory Change Summary
.github/workflows/ Removed branch exclusions in multiple workflow files, simplifying trigger conditions
apps/unicorn-app/ Completely removed entire application directory and all associated configuration files
charts/islandis/values.*.yaml Removed unicorn-app service configurations across dev, staging, and prod environments
charts/services/unicorn-app/ Deleted entire directory with environment-specific value configurations
infra/src/uber-charts/islandis.ts Removed unicornAppSetup service configuration and references
tsconfig.base.json Removed path mapping for @island.is/unicorn-app/*
scripts/ci/ Deleted utility scripts related to unicorn application

Suggested labels

cleanup, infrastructure, ci-cd

Suggested reviewers

  • busla
  • infrastructure-team-lead
  • devops-engineer

Possibly related PRs

  • Workflow configuration standardization PR
  • Infrastructure cleanup initiative
  • Deployment pipeline optimization project

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19553a3 and 1ed4c4e.

⛔ Files ignored due to path filters (1)
  • apps/unicorn-app/public/favicon.ico is excluded by !**/*.ico
📒 Files selected for processing (40)
  • .github/workflows/config-values.yaml (0 hunks)
  • .github/workflows/external-checks.yml (1 hunks)
  • .github/workflows/merge-queue-ci.yml (0 hunks)
  • .github/workflows/pullrequest-close.yml (0 hunks)
  • .github/workflows/pullrequest-lint.yml (0 hunks)
  • .github/workflows/pullrequest.yml (1 hunks)
  • .github/workflows/push.yml (0 hunks)
  • .github/workflows/revert-pr.yaml (0 hunks)
  • .github/workflows/unicorns.yml (0 hunks)
  • .gitignore (0 hunks)
  • apps/unicorn-app/.eslintrc.json (0 hunks)
  • apps/unicorn-app/codegen.yml (0 hunks)
  • apps/unicorn-app/index.d.ts (0 hunks)
  • apps/unicorn-app/infra/infra.ts (0 hunks)
  • apps/unicorn-app/jest.config.ts (0 hunks)
  • apps/unicorn-app/next-env.d.ts (0 hunks)
  • apps/unicorn-app/next.config.js (0 hunks)
  • apps/unicorn-app/project.json (0 hunks)
  • apps/unicorn-app/server.ts (0 hunks)
  • apps/unicorn-app/specs/index.spec.tsx (0 hunks)
  • apps/unicorn-app/src/app/api/hello/route.ts (0 hunks)
  • apps/unicorn-app/src/app/global.css (0 hunks)
  • apps/unicorn-app/src/app/layout.tsx (0 hunks)
  • apps/unicorn-app/src/app/page.module.css (0 hunks)
  • apps/unicorn-app/src/app/page.tsx (0 hunks)
  • apps/unicorn-app/tsconfig.json (0 hunks)
  • apps/unicorn-app/tsconfig.server.json (0 hunks)
  • apps/unicorn-app/tsconfig.spec.json (0 hunks)
  • apps/unicorn-app/webpack.config.js (0 hunks)
  • charts/islandis/values.dev.yaml (0 hunks)
  • charts/islandis/values.prod.yaml (0 hunks)
  • charts/islandis/values.staging.yaml (0 hunks)
  • charts/services/unicorn-app/values.dev.yaml (0 hunks)
  • charts/services/unicorn-app/values.prod.yaml (0 hunks)
  • charts/services/unicorn-app/values.staging.yaml (0 hunks)
  • infra/src/uber-charts/islandis.ts (0 hunks)
  • scripts/ci/create-release.mjs (0 hunks)
  • scripts/ci/get-last-release.mjs (0 hunks)
  • scripts/ci/unicorn-utils.mjs (0 hunks)
  • tsconfig.base.json (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@robertaandersen robertaandersen merged commit 27a704f into main Dec 20, 2024
27 of 30 checks passed
@robertaandersen robertaandersen deleted the revert-17308-uni-pr branch December 20, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant