fix(auth-delegations): Fix missing domains for legal representative delegations

[GunnlaugurG]

What

Fix missing domains for legal representative delegations (#17304)

• attempt to fix delegation bugs

• add filterOutForDelegationType to utils func

• Utils func changes

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.72%. Comparing base (2eebb1d) to head (a37fee8).
Report is 1 commits behind head on release/33.2.0.

Files with missing lines	Patch %	Lines
.../src/lib/resources/delegation-resources.service.ts	44.44%	5 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/33.2.0   #17320   +/-   ##
===============================================
  Coverage           35.71%   35.72%           
===============================================
  Files                6930     6931    +1     
  Lines              147920   147933   +13     
  Branches            42180    42182    +2     
===============================================
+ Hits                52833    52842    +9     
- Misses              95087    95091    +4     

Flag	Coverage Δ
api	3.33% <ø> (ø)
api-domains-auth-admin	48.49% <ø> (ø)
application-system-api	38.76% <ø> (+0.01%)	⬆️
application-template-api-modules	27.80% <ø> (+<0.01%)	⬆️
services-auth-admin-api	52.56% <26.08%> (-0.01%)	⬇️
services-auth-delegation-api	58.55% <34.78%> (-0.01%)	⬇️
services-auth-ids-api	52.56% <60.86%> (+<0.01%)	⬆️
services-auth-public-api	49.41% <56.52%> (-0.01%)	⬇️
services-user-notification	46.59% <ø> (+<0.01%)	⬆️
services-user-profile	57.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ib/src/lib/delegations/delegation-scope.service.ts	91.52% <100.00%> (+0.22%)	⬆️
...delegations/delegations-incoming-custom.service.ts	91.46% <100.00%> (-0.26%)	⬇️
.../delegations/utils/filterByScopeCustomScopeRule.ts	100.00% <100.00%> (ø)
...auth-api-lib/src/lib/resources/resources.module.ts	100.00% <100.00%> (ø)
.../src/lib/resources/delegation-resources.service.ts	95.27% <44.44%> (-3.06%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eebb1d...a37fee8. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs c29c859 🔗

✅ 10 Total Test Services: 0 Failed, 8 Passed
⬆️ Test Sessions change in coverage: 6 increased, 18 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.4s	1 no change	Link
api-domains-auth-admin	0	0	0	18	0	9.98s	1 no change	Link
application-system-api	0	0	0	46	0	2m 10.04s	1 increased (+0.06%)	Link
application-template-api-modules	0	0	0	118	0	2m 4.21s	1 increased (+0.12%)	Link
auth-api-lib	0	0	0	20	0	27.43s	1 no change	Link
services-auth-admin-api	0	0	0	130	0	3m 7.69s	1 no change	Link
services-auth-delegation-api	0	0	0	270	0	3m 4.43s	1 increased (+0.01%)	Link
services-auth-ids-api	0	0	0	262	0	1m 14.42s	1 no change	Link
services-auth-personal-representative	0	0	0	0	0	273.12ms	1 no change	Link
services-auth-personal-representative-public	0	0	0	0	0	261.92ms	1 no change	Link